Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish default dictionary not working #18

Closed
Kendbi opened this issue Jan 14, 2020 · 7 comments
Closed

Polish default dictionary not working #18

Kendbi opened this issue Jan 14, 2020 · 7 comments

Comments

@Kendbi
Copy link

Kendbi commented Jan 14, 2020

While using polish dictionary only suggested words appearing are the ones I had already written on my own.

@dslul
Copy link
Member

dslul commented Jan 22, 2020

I added the polish dictionary in the latest commit 7b9f216

@gjallarhorn
Copy link

Would it be too extreme to add all of the European languages (24)? Made a quick calculation and the total size for adding the ones missing, would be around 20 MB.

@dslul
Copy link
Member

dslul commented Jan 23, 2020

Would it be too extreme to add all of the European languages (24)? Made a quick calculation and the total size for adding the ones missing, would be around 20 MB.

It could be done, I wrote some instructions in the readme on how to add languages, it's very simple if you already have the dictionary (like these https://github.com/dslul/openboard/tree/master/dictionaries)

@alensiljak
Copy link

@dslul,

I wrote some instructions in the readme on how to add languages

I don't see these instructions in the readme. There is only mention of how to create dictionaries. Guess it should be obvious from reading the code? Let me try. :)

@dslul
Copy link
Member

dslul commented Jan 24, 2020

I don't see these instructions in the readme. There is only mention of how to create dictionaries. Guess it should be obvious from reading the code? Let me try. :)

I know, I didn't wrote great instructions, anyway it's really simple, just download dicttool (from that link) and then, from command line, convert to binary the dictionary:
java -jar dicttool_aosp.jar makedict -s en_wordlist.combined -d main_en.dict
where en_wordlist.combined is the text wordlist (there are some - compressed - in the dictionaries folder, not all were converted to binary). main_it.dict is the output, it should be put in the res folder. Of course, change "en" with the language specified in the dict.

@dslul
Copy link
Member

dslul commented Jan 27, 2020

@Kendbi I added polish in v1.3, if it doesn't work for you, I'll reopen this issue.

@dslul dslul closed this as completed Jan 27, 2020
@ihfandicahyo
Copy link

Sir @dslul sorry for spam here. Can you help ppl on remi0s/aosp-dictionary-tools#1 to fix this? I have same issue :( TIA

lukaszgdula6 pushed a commit to lukaszgdula6/openboard that referenced this issue Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants