OpencBot configuration from Analysis App #112
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjessop12
force-pushed
the
openc_bot_config_for_fetchers
branch
11 times, most recently
from
a61333b
to
a35a1a5
Compare
This commit allows a fetcher bot to retrieve information about the bot from Analysis App's bots.json output. We will need the jurisdiction_code to be able to pull the data from the JSON. I considered using a Proc select method of getting this data, as it reads nicer, bu this is slightly more performative.
benjessop12
force-pushed
the
openc_bot_config_for_fetchers
branch
11 times, most recently
from
bf263fe
to
b7ca96c
Compare
added 4 commits
April 15, 2020 15:36
PR #53 in Analysis App will return a hash value based on what is stored in the database, to which we will allow the fetcher to access as an OpenStruct.
Travis was complaining about this, so this is to make the integration tests pass.
Spec tests to indicate the behaviour of the new module.
There are many entry points for running an openc_bot, so we will need to return this if already called.
benjessop12
force-pushed
the
openc_bot_config_for_fetchers
branch
from
b7ca96c
to
8c39c96
Compare
benjessop12
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading configuration settings from the analysis app
https://opencorporates.atlassian.net/browse/DAT-3550