Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

critwall: use Protocol.securityMethod to decide how to authenticate download calls #292

Closed
pdowler opened this issue Apr 19, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@pdowler
Copy link
Member

pdowler commented Apr 19, 2021

critwall requests both https,anon and https,cert URLs during transfer negotiation, but needs to be careful to make the call using the resulting security method (specifically, make downloads anonymously).

so, instead of the Subject.doAs(...) in run() that provides a client cert to all https requests, it should

  • do a Subject.doAs in getDownloadURLs (transfer negotation) and return a List
  • conditonally do Subject.doAs in syncArtifact, depending on the securityMethod

This will remove extraneous/unecessary authentication and overhead that goes with it.

@pdowler pdowler added the enhancement New feature or request label Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant