Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert back to a stable version of grunt-cli #188

Closed
JulianKniephoff opened this issue Oct 12, 2018 · 0 comments
Closed

Revert back to a stable version of grunt-cli #188

JulianKniephoff opened this issue Oct 12, 2018 · 0 comments

Comments

@JulianKniephoff
Copy link
Member

41b1ce4 changed the grunt-cli dependency to the master branch of that project. This was done to get the benefits of gruntjs/grunt-cli#123, namely compatibility with Node 10. Once there is a release containing that PR, we should revert back to a stable dependency.

JulianKniephoff added a commit to JulianKniephoff/annotation-tool that referenced this issue Nov 21, 2018
mliradelc added a commit to mliradelc/annotation-tool that referenced this issue Jun 24, 2019
# This is the 1st commit message:

Add HLS support

Update files from develop branch

Fixed German translation file syntax

Closes opencast#173.

Add Emacs configuration

`npm update && npm audit fix`

Changed `less` plugin for `grunt`

This switches from `assemble-less` to `grunt-contrib-less`
and updates the latter at least a bit,
all in order to get rid of a few security vulnerabilities.
Further updates pending mostly because of incompatibilities.

Updated `grunt-contrib-less` to the latest version

More package updates

# This is the commit message #2:

Removed unused grunt plugin

# This is the commit message #3:

Removed some unused dependencies

# This is the commit message #4:

Improved code quality

# This is the commit message #5:

Removed some dead code and obsolete comments

# This is the commit message #6:

Got rid of `box-sizing`-'polyfill"

Box sizing has good enough support now.
If we still want backwards compat,
I feel like a CSS postprocessor
would be a better approach.

# This is the commit message opencast#7:

Simplified some event handling code

# This is the commit message opencast#8:

Refactored comment model slightly

Comments should be creatable without text.
But I **do** see the problem this brings.
So why not make the empty string the default text? ;)

# This is the commit message opencast#9:

Refactored some view cleanup and deleted related dead code

# This is the commit message opencast#10:

Allowed editing multiple annotations simultaneously

# This is the commit message opencast#11:

Use `maven-enforcer-plugin` instead of `prerequisites`

Fixes opencast#187.

# This is the commit message opencast#12:

Pinned `maven-install-plugin`

Fixes opencast#185.

# This is the commit message opencast#13:

Added an `npm start` script

# This is the commit message opencast#14:

Updated `grunt-cli`

# This is the commit message opencast#15:

Improved code quality

# This is the commit message opencast#16:

Revert back to a stable version of `grunt-cli`

Closes opencast#188.

# This is the commit message opencast#17:

Fix XACML parsing of rules

OAT filters for ACL rules with the wrong tag name "rules" instead of
"Rule".

# This is the commit message opencast#18:

Fix exception during export when no e-mail is set

# This is the commit message opencast#19:

Simplified some of the export functions a bit

# This is the commit message opencast#20:

Remove unused and vulnerable dependency

# This is the commit message opencast#21:

Updated demo link in the README

Changed the README to include a link to a working demo
# This is the commit message opencast#22:

Update README.md
# This is the commit message opencast#23:

Update checkstyle to fix a vulnerability

# This is the commit message opencast#24:

Improve the style of the checkstyle configuration

# This is the commit message opencast#25:

Update `grunt`
mliradelc added a commit to mliradelc/annotation-tool that referenced this issue Jun 24, 2019
author Maximiliano Lira Del Canto <8040628+mliradelc@users.noreply.github.com> 1561375325 +0200
committer Maximiliano Lira Del Canto <8040628+mliradelc@users.noreply.github.com> 1561375325 +0200
gpgsig -----BEGIN PGP SIGNATURE-----

 iQIzBAABCAAdFiEEKm48rSC3SfEdW71MJ39kvWO4J9cFAl0QsmEACgkQJ39kvWO4
 J9f3/g//dbtNFP/WmIHOq/cpMDHahl2TkpO3WJlHt8vLjBzJSw5EVRHH4agR0QVT
 BVNDm0yaL/00yzq9Mt250m22MZDxiT+sh5Xk0K1EEoJ8yImmY2PHEaxTwYS7bozh
 8vMhrb+AwPnmDh8mlV/iL3cZG+6M3pFABlnh1CijXfgJwYfrYD6+XIV+Cjf8Ps0P
 ccYaAixHVzNJAIe0lW/B8olIbq9P7TvRytxSdhZUL7XjcZTY5WQZcUvED1UWZLGr
 Vl+7Yk6Qb1Qs6IwZCmstjpzoHbE82jzx1RaNYCYggWVSOee/LJePIjmk4veirSVK
 4fhddFE8ssr7FIDKMkhVDOAS5eqANIe9GWss37P22PVA4UmiBfhb+J2tP5DFfvUf
 0DihxbRcGVEs3Tz5KyKpUakYH0P8Mt5ro+cOUtl9NcBp1eAyTDZiWx3ODZVper5L
 uPCiZPgO5Pktk+dlmexDhA8lJ9Is7N56RGfGcJ993H5+12mvUI0JJpCQ4oC25AC4
 zQpUv9hvzHC9vrKqQiuE1LJ3zlPk9+lNxvZhqHucwpiVdEcc21kSrsPucdf2u+wZ
 XxFQY/W0cWGmMO+gpSeeCC/3mz5yJ0KiTR2bT/4euyxNBl4U7jF6Td3Kun+tDVo1
 nBfAMvToguBjjSXJv7AA0WOdAgw+D3YdEDr2jZGXccKHPN4lZzY=
 =ToI9
 -----END PGP SIGNATURE-----

Add HLS support

Update files from develop branch

Fixed German translation file syntax

Closes opencast#173.

Add Emacs configuration

`npm update && npm audit fix`

Changed `less` plugin for `grunt`

This switches from `assemble-less` to `grunt-contrib-less`
and updates the latter at least a bit,
all in order to get rid of a few security vulnerabilities.
Further updates pending mostly because of incompatibilities.

Updated `grunt-contrib-less` to the latest version

More package updates

Removed unused grunt plugin

Removed some unused dependencies

Improved code quality

Removed some dead code and obsolete comments

Got rid of `box-sizing`-'polyfill"

Box sizing has good enough support now.
If we still want backwards compat,
I feel like a CSS postprocessor
would be a better approach.

Simplified some event handling code

Refactored comment model slightly

Comments should be creatable without text.
But I **do** see the problem this brings.
So why not make the empty string the default text? ;)

Refactored some view cleanup and deleted related dead code

Allowed editing multiple annotations simultaneously

Use `maven-enforcer-plugin` instead of `prerequisites`

Fixes opencast#187.

Pinned `maven-install-plugin`

Fixes opencast#185.

Added an `npm start` script

Updated `grunt-cli`

Improved code quality

Revert back to a stable version of `grunt-cli`

Closes opencast#188.

Fix XACML parsing of rules

OAT filters for ACL rules with the wrong tag name "rules" instead of
"Rule".

Fix exception during export when no e-mail is set

Simplified some of the export functions a bit

Remove unused and vulnerable dependency

Updated demo link in the README

Changed the README to include a link to a working demo

Update README.md

Update checkstyle to fix a vulnerability

Improve the style of the checkstyle configuration

Update `grunt`

Update `grunt-jsdoc`

Improve the documentation

This fixes Markdown formatting issues and dangling URLs in the documentation.

Add new `copy:config-build` step, to make the `build` profile work

Raise lower bound of Opencast version range

This is just a cosmetic change;
you probably have to specify the version explicity, anyway.
But at least it signals the versions supported.

Remove `opencast.artifactPrefix` option

Now that Opencast < 5 is well beyond it's support,
we can drop this hack to work around the module renaming.

Made comment counts update recursively

Improved code quality

Fixed the translations of the view titles

Translate GoldenLayout tab titles on the fly

Fixes opencast#183.

Preliminary fix for category editing controls in Firefox

Closes opencast#158.

Use wrapper provided by MediaElement.js to listen for player events

Remove redundant shim configuration

Update MediaElement.js

This also uses the unminified version for now, to aid in debugging.
We should really let the build system minify these files.

Only initialize the player if the container is already in the DOM

MediaElement's fill-mode needs access to the dimensions
of its parent element in order to adapt its own elements.
This is impossible when they are not part of the DOM, yet.

Remove test for the `/reset` endpoint

This endpoint will no longer be part of the public API.

Move the `/reset` endpoint to the test REST endpoint

Unfortunately it is still necessary here, because the tests
rely on the fact that everything is cleaned up in between
test cases, and I don't have access to the underlying service
at this point.

Simplify the POM structure

Modern versions of Maven allow us to specify the version of the parent
using a property from said parent.

Update `node` to a version that supports all our dependencies

Make sure we notice when deps are incompatible with our node version

Remove `npm` version specification

Without it, the `maven-frontend-plugin` picks
whatever the specified `node` version comes with,
which should be fine.
And if it is not, we will notice it hopefully,
thanks to `--engine-strict`.

Remove redundant `npm clean`

Adapt to Opencast's new `rest-test-environment` module

`package-lock.json` changes probably due to new `node`

Prepare for cutting the release branch

Put `opencast-rest-test-environment` in a profile

This profile will be deactivated by `maven.test.skip`,
so that we don't even look at it when we skip tests.
This is needed to make building (without tests)
against Opencast 6 work again.

Improve the documentation

Implement shortcuts for the first 9 categories/labels/scale values

Rename `AnnotateView#toggleFreeTextAnnotations`

It does not actually goggle the annotations,
but the pane to create new ones.
Plus: We need that other name now. ;)

Align button text in navbars with normal text

Fix icon sizes for the non-black icons

Simplify some markup

Add button to toggle free text annotations

Actually show/hide free text annotations appropriately

Enable global play/pause using the spacebar

Change loop controller constraints when changing the active loop

Fixes opencast#231.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant