Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update v8flags to support Node 10 #123

Merged
merged 1 commit into from
Sep 26, 2018
Merged

Update v8flags to support Node 10 #123

merged 1 commit into from
Sep 26, 2018

Conversation

JulianKniephoff
Copy link
Contributor

With Node 10 (v10.11.0 to be precise) I get the following error when running---among other commands---grunt --force:

/usr/bin/node: bad option: --force

This seems to be the fault of v8flags, somehow. This update fixes that.

@jsf-clabot
Copy link

jsf-clabot commented Sep 26, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@vladikoff vladikoff merged commit b1dd2ee into gruntjs:master Sep 26, 2018
@JulianKniephoff JulianKniephoff mentioned this pull request Oct 12, 2018
Closed
@Arkni Arkni mentioned this pull request Nov 4, 2018
Closed
@Arkni
Copy link
Member

Arkni commented Nov 5, 2018

@JulianKniephoff

FYI, this change was published to npm as v1.3.2

@JulianKniephoff
Copy link
Contributor Author

Thanks! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladikoff vladikoff vladikoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JulianKniephoff @jsf-clabot @Arkni @vladikoff