Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump reselect from 4.1.8 to 5.1.0 #436

Merged
merged 1 commit into from
May 31, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 23, 2024

Bumps reselect from 4.1.8 to 5.1.0.

Release notes

Sourced from reselect's releases.

v5.1.0

This minor release:

  • Adds a new createSelector.withTypes<RootState>() and createStructuredSelector.withTypes<RootState>() API
  • Deprecates the TypedStructuredSelectorCreator type introduced in 5.0
  • Aims to reduce false positives in identityFunctionCheck by only running if the output selector is passed one argument
  • Fixes a bug with weakMapMemoize's resultEqualityCheck when used with a primitive result.

withTypes

Most commonly, selectors will accept the root state of a Redux store as their first argument. withTypes allows you to specify what that first argument will be ahead of creating the selector, meaning it doesn't have to be specified.

// previously
export const selectPostById = createSelector(
  [
    (state: RootState) => state.posts.entities,
    (state: RootState, id: number) => id,
  ],
  (entities, id) => entities[id],
);
// now
export const createAppSelector = createSelector.withTypes<RootState>();
export const selectPostById = createAppSelector(
[(state) => state.posts.entities, (state, id: number) => id],
(entities, id) => entities[id],
);

Known limitations

Due to a Typescript issue, inference of the output selector's parameters only works with withTypes when using an array of input selectors.

If using the variadic version, you can either wrap your input selectors in an array instance (as above), or annotate the parameters manually.

export const createAppSelector = createSelector.withTypes<RootState>();
export const selectPostById = createAppSelector(
(state) => state.posts.entities,
(state, id: number) => id,
// parameters cannot be inferred, so need annotating
(entities: Record<number, Post>, id: number) => entities[id],
);

What's Changed

... (truncated)

Commits
  • f7e5b73 Release 5.1.0
  • d67d01a add version plugin
  • 978ef3c Merge pull request #668 from aryaemami59/bump-vitest
  • a39fe9e Merge pull request #678 from aryaemami59/createStructuredSelector-withTypes
  • 1368970 Change version to 5.0.2 to workaround CI issue
  • 025c1a4 Remove TypedStructuredSelectorCreator from docs
  • 140f38f Remove createStructuredAppSelector.ts from examples
  • 73e45f7 Remove TypedStructuredSelectorCreator from README
  • 9b4b7ac Add todo comments to remove certain test blocks
  • 7f1588c Modify JSDocs for TypedStructuredSelectorCreator
  • Additional commits viewable in compare view
Maintainer changes

This version was pushed to npm by eskimojo, a new releaser for reselect since your current version.


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the type:dependencies Pull requests that update a dependency file label May 23, 2024
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/reselect-5.1.0 branch from d3d2e01 to dcf3be6 Compare May 23, 2024 14:27
@ziegenberg
Copy link
Member

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/reselect-5.1.0 branch from dcf3be6 to f4c4c92 Compare May 29, 2024 11:58
Copy link
Contributor

github-actions bot commented May 29, 2024

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-436

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-436

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/reselect-5.1.0 branch 2 times, most recently from e819604 to 7a3755d Compare May 31, 2024 10:09
@ziegenberg
Copy link
Member

@dependabot rebase

Bumps [reselect](https://github.com/reduxjs/reselect) from 4.1.8 to 5.1.0.
- [Release notes](https://github.com/reduxjs/reselect/releases)
- [Changelog](https://github.com/reduxjs/reselect/blob/master/CHANGELOG.md)
- [Commits](reduxjs/reselect@v4.1.8...v5.1.0)

---
updated-dependencies:
- dependency-name: reselect
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/reselect-5.1.0 branch from 7a3755d to 29f2359 Compare May 31, 2024 15:26
Copy link
Contributor

This pull request is deployed at test.admin-interface.opencast.org/436/2024-05-31_15-26-22/ .
It might take a few minutes for it to become available.

@lkiesow lkiesow self-assigned this May 31, 2024
@lkiesow lkiesow merged commit d36bd0a into main May 31, 2024
5 checks passed
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/reselect-5.1.0 branch May 31, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants