Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some vite nitpicks #515

Merged
merged 7 commits into from
Jun 4, 2024

Conversation

JulianKniephoff
Copy link
Member

This does several things:

See individual commits and their messages for more details.

Copy link
Contributor

github-actions bot commented Jun 3, 2024

This pull request is deployed at test.admin-interface.opencast.org/515/2024-06-03_17-59-00/ .
It might take a few minutes for it to become available.

Copy link
Contributor

github-actions bot commented Jun 3, 2024

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-515

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-515

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@ziegenberg
Copy link
Member

It still builds, it runs and the changes make sense. (I had a branch with the same fixes on my machine)

@ziegenberg ziegenberg added the type:code-enhancement Internal improvements to the codebase label Jun 4, 2024
@ziegenberg ziegenberg merged commit 8b92f85 into opencast:main Jun 4, 2024
5 checks passed
@ziegenberg ziegenberg self-assigned this Jun 4, 2024
@JulianKniephoff JulianKniephoff deleted the vite-deprecation-warning branch June 4, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:code-enhancement Internal improvements to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants