Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type error when opening statistics page #568

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

ferishili
Copy link
Contributor

This PR fixes #566
by properly async call (using dispatch!) to fetch the user info before fetching the statistics info!
This PR needs actual statistic data to make sure it works properly, but for the start the error is now gone, and the page should not be interrupted!

Screenshot 2024-06-04 at 14 08 26

Copy link
Contributor

github-actions bot commented Jun 4, 2024

Hi @ferishili
Thank you for contributing to the Opencast Editor.
We noticed that you have not yet filed an Individual Contributor License Agreement. Doing that (once) helps us to ensure that Opencast stays free for all. If you make your contribution on behalf of an institution, you might also want to file a Corporate Contributor License Agreement (giving you as individual contributor a bit more security as well). It can take a while for this bot to find out about new filings, so if you just filed one or both of the above do not worry about this message!
Please let us know if you have any questions regarding the CLA.

Copy link
Contributor

github-actions bot commented Jun 4, 2024

This pull request is deployed at test.admin-interface.opencast.org/568/2024-06-04_12-08-55/ .
It might take a few minutes for it to become available.

Copy link
Contributor

github-actions bot commented Jun 4, 2024

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-568

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-568

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@ferishili ferishili changed the title Fix Statistics overview page! Fix type error when opening statistics page Jun 4, 2024
@ziegenberg
Copy link
Member

ziegenberg commented Jun 4, 2024

This also fixes #282

Edit: I was wrong!

@ziegenberg ziegenberg self-requested a review June 4, 2024 12:20
@ziegenberg ziegenberg added the type:bug Something isn't working label Jun 4, 2024
@ziegenberg
Copy link
Member

Note: ICLA has been filed (see #546 (comment))

Copy link
Contributor

github-actions bot commented Jun 4, 2024

This pull request is deployed at test.admin-interface.opencast.org/568/2024-06-04_12-29-51/ .
It might take a few minutes for it to become available.

@ferishili
Copy link
Contributor Author

ferishili commented Jun 4, 2024

Keep in mind that I haven't tested this for #282 (which happens in events details level)
I found this bug simply by navigating to the statistics menu in left pane action bar!

@ferishili ferishili requested a review from ziegenberg June 4, 2024 12:32
Copy link
Member

@ziegenberg ziegenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does what it says on the tin

@ziegenberg ziegenberg merged commit 3867c81 into opencast:main Jun 4, 2024
5 checks passed
@ziegenberg ziegenberg self-assigned this Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when opening Statistics Page
2 participants