Remove dead code in video header #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent dependency updates have caused a type mismatch. This quells the mismatch by basically replacing null with undefined.
Removes code that would display presenters in the video title in the cutting view. Displaying presenters has been removed from the backend for quite some time now and no one seems to have minded, so I think this can just go. Also resolves opencast#887 while I'm at it. (Contains opencast#892)
|
This pull request is deployed at test.editor.opencast.org/905/2022-11-18_14-04-54/ . |
github-actions
bot
added
the
status:conflicts
|
This pull request has conflicts ☹ |
github-actions
bot
removed
the
status:conflicts
|
This pull request is deployed at test.editor.opencast.org/905/2022-12-19_08-51-08/ . |
github-actions
bot
added
the
status:conflicts
|
This pull request has conflicts ☹ |
lkiesow
approved these changes
Mar 18, 2023
github-actions
bot
removed
the
status:conflicts
|
This pull request is deployed at test.editor.opencast.org/905/2023-03-20_09-48-43/ . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes code that would display presenters in the video title in the
cutting view. Displaying presenters has been removed from the backend
for quite some time now and no one seems to have minded, so I think
this can just go.
Also resolves #887 while I'm at it.
(Contains #892)