Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ffmpeg version in Dockerfile #368

Closed
pitfisher opened this issue Feb 3, 2022 · 6 comments · Fixed by #369
Closed

Update ffmpeg version in Dockerfile #368

pitfisher opened this issue Feb 3, 2022 · 6 comments · Fixed by #369

Comments

@pitfisher
Copy link
Contributor

pitfisher commented Feb 3, 2022 •
edited
Loading

Hello! Can you please update the version of ffmpeg used in pyCA's Dockerfile? I'm looking for SRT protocol support. I successfully built local pyCA Docker image with this ffmpeg build and it has SRT support, but it'd be much more convenient to have it in your image. The link to the page with the link to this build is present on an official ffmpeg download page so I guess it's safe to use.
@lkiesow
Copy link
Member

lkiesow commented Feb 3, 2022

You are right, that version should work.
Can you file a pull request changing the Dockerfile?

@pitfisher
Copy link
Contributor Author

pitfisher commented Feb 3, 2022 •
edited
Loading

Thank you for the quick reply!
I filed a pull request

@mtneug
Copy link
Member

mtneug commented Feb 3, 2022

Why don't we use the ffmpeg version we build ourselves? If SRT support is missing we should add it.

@lkiesow
Copy link
Member

lkiesow commented Feb 4, 2022

That's fine with me as well. For the overall issue, this doesn't matter which version we use.

Right now, the version built for Opencast also target's codecs that Opencast usually needs.
Streaming protocols like SRT and desktop audio and video capture protocols (e.g. pulse) haven't been the focus of that.
But I see no reason why we couldn't add them. Just, I don't have the time to do that right now.
Still, I'm happy to see a pull request for that.

Are you planning to work on that short-term?

@mtneug
Copy link
Member

mtneug commented Feb 7, 2022 •
edited
Loading

Yes, I have a binary linked to libsrt, but have not tested it yet (as in never executed it).

Edit 1: srt is listed in -protocols

@lkiesow
Copy link
Member

lkiesow commented Mar 7, 2022

Would be nice to add that in the long run.
Short term, I'll just add the other FFmpeg binary.
Once we have updated our build process, we can switch back.

@lkiesow lkiesow mentioned this issue Mar 7, 2022
Merged
lkiesow pushed a commit that referenced this issue Mar 7, 2022
@pitfisher
Updated ffmpeg download source URL for newer ffmpeg version (#369)
576d439 
This updates the version of FFmpeg used in pyCA's containers to support additional protocols.
This uses the static binaries built by John Van Sickle.

This fixes #368
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated ffmpeg download source URL for newer ffmpeg version pitfisher/pyCA
3 participants
@lkiesow @mtneug @pitfisher