Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linting errors #152

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

mduffin95
Copy link
Contributor

@mduffin95 mduffin95 commented Feb 12, 2023

Pull Request

Description

Fixed a couple of bare except: issues. There may be a tighter exception that could be used though. Then ran black --line-length 100 satip which removed a few blank lines.

Fixes #137

How Has This Been Tested?

CI tests.

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@mduffin95 mduffin95 changed the title 137 fix linting errors Fix linting errors Feb 12, 2023
@mduffin95 mduffin95 marked this pull request as ready for review February 12, 2023 22:10
Copy link
Member

@jacobbieker jacobbieker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@mduffin95
Copy link
Contributor Author

No problem, I'd be keen to contribute more!

@jacobbieker jacobbieker merged commit be54e15 into openclimatefix:main Feb 14, 2023
@jacobbieker
Copy link
Member

No problem, I'd be keen to contribute more!

Great! We do have the list of other good first issues, if you want to poke around!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix linting errors
2 participants