Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split into HRV and all other Zarr stores #23

Merged
merged 3 commits into from
Oct 27, 2021
Merged

Split into HRV and all other Zarr stores #23

merged 3 commits into from
Oct 27, 2021

Conversation

jacobbieker
Copy link
Member

@jacobbieker jacobbieker commented Oct 27, 2021 •
edited
Loading

Pull Request

Description

Split into two data stores, one for HRV high-resolution images, and one for the lower resolution all other images.

Fixes #14

How Has This Been Tested?

Tested locally.

  • No
  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@jacobbieker jacobbieker self-assigned this Oct 27, 2021
@jacobbieker
Copy link
Member Author

Removing the resampling also dramatically speeds up the code as well

JackKelly
JackKelly approved these changes Oct 27, 2021
View reviewed changes
Copy link
Member

@JackKelly JackKelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! That was fast! And that's great news that this also speeds things up.

@jacobbieker jacobbieker merged commit dc87680 into main Oct 27, 2021
@jacobbieker jacobbieker deleted the jacob/split-zarr branch October 27, 2021 16:06
@jacobbieker jacobbieker mentioned this pull request Oct 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackKelly JackKelly JackKelly approved these changes

Assignees

@jacobbieker jacobbieker

Labels
None yet
Projects
No open projects
Nowcasting
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write script to convert .nat EUMETSAT files to Zarr intermediate
2 participants
@jacobbieker @JackKelly