Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix same object being removed multiple times (#2048) #108

Merged
merged 8 commits into from
May 22, 2019

Commits on May 2, 2019

  1. Fix bug #2048: Duplicate removal by AbortCall

    Assume you have an object with action "AbortAction" that has an
    AbortCall="RemoveObject", or an abort call that removes the object.
    
    Then, removing the object while it has "AbortAction" will remove it
    twice, reducing the Def->Count by 2, while only one object was removed.
    
    This does not do very much, but if you have only one object of that type
    and later check for object count after you create a new one, then
    creating the new object increases the Def->Count from -1 to 0 and the
    new object is not found by Find_ID(), even though it exists.
    gitMarky committed May 2, 2019
    Configuration menu
    Copy the full SHA
    2de69bd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2b61756 View commit details
    Browse the repository at this point in the history
  3. Code style and some checks

    gitMarky committed May 2, 2019
    Configuration menu
    Copy the full SHA
    9999d9f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1a84bea View commit details
    Browse the repository at this point in the history

Commits on May 3, 2019

  1. Configuration menu
    Copy the full SHA
    f2736b9 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2019

  1. Added comments

    gitMarky committed May 4, 2019
    Configuration menu
    Copy the full SHA
    a7bbdd1 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2019

  1. Handle removal cancellation via RemovalDelay

    This solves the problem that adding a new status introduced.
    gitMarky committed May 17, 2019
    Configuration menu
    Copy the full SHA
    46b884c View commit details
    Browse the repository at this point in the history
  2. Remove unnecessary callbacks

    These were necessary before, because the object could be deleted in each
    callback. Now we make sure that the function runs without the object
    being deleted a second time, so the callbacks could be removed.
    
    With the less bloated code the recently introduced function
    FinishRemoval became unnecessary.
    gitMarky committed May 17, 2019
    Configuration menu
    Copy the full SHA
    c007be2 View commit details
    Browse the repository at this point in the history