-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix same object being removed multiple times (#2048) #108
Merged
Commits on May 2, 2019
-
Fix bug #2048: Duplicate removal by AbortCall
Assume you have an object with action "AbortAction" that has an AbortCall="RemoveObject", or an abort call that removes the object. Then, removing the object while it has "AbortAction" will remove it twice, reducing the Def->Count by 2, while only one object was removed. This does not do very much, but if you have only one object of that type and later check for object count after you create a new one, then creating the new object increases the Def->Count from -1 to 0 and the new object is not found by Find_ID(), even though it exists.
Configuration menu - View commit details
-
Copy full SHA for 2de69bd - Browse repository at this point
Copy the full SHA 2de69bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b61756 - Browse repository at this point
Copy the full SHA 2b61756View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9999d9f - Browse repository at this point
Copy the full SHA 9999d9fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a84bea - Browse repository at this point
Copy the full SHA 1a84beaView commit details
Commits on May 3, 2019
-
Configuration menu - View commit details
-
Copy full SHA for f2736b9 - Browse repository at this point
Copy the full SHA f2736b9View commit details
Commits on May 4, 2019
-
Configuration menu - View commit details
-
Copy full SHA for a7bbdd1 - Browse repository at this point
Copy the full SHA a7bbdd1View commit details
Commits on May 17, 2019
-
Handle removal cancellation via RemovalDelay
This solves the problem that adding a new status introduced.
Configuration menu - View commit details
-
Copy full SHA for 46b884c - Browse repository at this point
Copy the full SHA 46b884cView commit details -
These were necessary before, because the object could be deleted in each callback. Now we make sure that the function runs without the object being deleted a second time, so the callbacks could be removed. With the less bloated code the recently introduced function FinishRemoval became unnecessary.
Configuration menu - View commit details
-
Copy full SHA for c007be2 - Browse repository at this point
Copy the full SHA c007be2View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.