Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/core reaction #1171

Merged
merged 11 commits into from
Mar 12, 2022
Merged

Refactor/core reaction #1171

merged 11 commits into from
Mar 12, 2022

Conversation

akaviaLab
Copy link
Contributor

  • description of feature/fix
    Updated reaction.py and test_core_reaction.py to be Python 3.6+ compliant.
    I didn't fully fix memo in deepcopy, because I don't know what it is supposed to be and/or do.

@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2022 •
edited
Loading

Codecov Report

Merging #1171 (b2a078d) into devel (684f66e) will decrease coverage by 0.09%.
The diff coverage is 89.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel    #1171      +/-   ##
==========================================
- Coverage   84.00%   83.90%   -0.10%     
==========================================
  Files          65       65              
  Lines        5365     5363       -2     
  Branches     1240     1241       +1     
==========================================
- Hits         4507     4500       -7     
- Misses        549      553       +4     
- Partials      309      310       +1
Impacted Files Coverage Δ
src/cobra/core/reaction.py 86.88% <89.47%> (-1.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 684f66e...b2a078d. Read the comment docs.

synchon
synchon reviewed Mar 11, 2022
View reviewed changes
src/cobra/core/reaction.py Outdated Show resolved Hide resolved
synchon
synchon reviewed Mar 11, 2022
View reviewed changes
src/cobra/core/reaction.py Outdated Show resolved Hide resolved
synchon
synchon reviewed Mar 11, 2022
View reviewed changes
src/cobra/core/reaction.py Outdated Show resolved Hide resolved
synchon
synchon reviewed Mar 11, 2022
View reviewed changes
src/cobra/core/reaction.py Outdated Show resolved Hide resolved
synchon
synchon reviewed Mar 11, 2022
View reviewed changes
src/cobra/core/reaction.py Outdated Show resolved Hide resolved
synchon
synchon reviewed Mar 11, 2022
View reviewed changes
src/cobra/core/reaction.py Outdated Show resolved Hide resolved
synchon
synchon reviewed Mar 11, 2022
View reviewed changes
src/cobra/core/reaction.py Outdated Show resolved Hide resolved
synchon
synchon reviewed Mar 11, 2022
View reviewed changes
src/cobra/core/reaction.py Outdated Show resolved Hide resolved
synchon
synchon reviewed Mar 11, 2022
View reviewed changes
src/cobra/core/reaction.py Outdated Show resolved Hide resolved
synchon
synchon reviewed Mar 11, 2022
View reviewed changes
src/cobra/core/reaction.py Outdated Show resolved Hide resolved
synchon
synchon reviewed Mar 11, 2022
View reviewed changes
src/cobra/core/reaction.py Outdated Show resolved Hide resolved
synchon
synchon reviewed Mar 11, 2022
View reviewed changes
src/cobra/core/reaction.py Outdated Show resolved Hide resolved
synchon
synchon reviewed Mar 11, 2022
View reviewed changes
src/cobra/core/reaction.py Outdated Show resolved Hide resolved
synchon
synchon reviewed Mar 11, 2022
View reviewed changes
src/cobra/core/reaction.py Outdated Show resolved Hide resolved
synchon
synchon reviewed Mar 11, 2022
View reviewed changes
src/cobra/core/reaction.py Outdated Show resolved Hide resolved
synchon
synchon reviewed Mar 11, 2022
View reviewed changes
src/cobra/core/reaction.py Outdated Show resolved Hide resolved
synchon
synchon reviewed Mar 11, 2022
View reviewed changes
src/cobra/core/reaction.py Outdated Show resolved Hide resolved
synchon
synchon reviewed Mar 11, 2022
View reviewed changes
src/cobra/core/reaction.py Outdated Show resolved Hide resolved
synchon
synchon reviewed Mar 11, 2022
View reviewed changes
src/cobra/core/reaction.py Outdated Show resolved Hide resolved
synchon
synchon reviewed Mar 11, 2022
View reviewed changes
src/cobra/core/reaction.py Outdated Show resolved Hide resolved
synchon
synchon reviewed Mar 11, 2022
View reviewed changes
src/cobra/core/reaction.py Outdated Show resolved Hide resolved
uri.akavia and others added 2 commits March 12, 2022 10:53
black on the merged versions
2397e86
@akaviaLab @Midnighter
fix raise_with_traceback
a9fb8a5 
https://docs.python.org/3/reference/simple_stmts.html#the-raise-statement indicates that 
raise err.with_traceback() is not necessary, despite what future documentation says.

Co-authored-by: Moritz E. Beber <midnighter@posteo.net>
synchon
synchon reviewed Mar 12, 2022
View reviewed changes
src/cobra/core/reaction.py Outdated Show resolved Hide resolved
synchon
synchon reviewed Mar 12, 2022
View reviewed changes
src/cobra/core/reaction.py Outdated Show resolved Hide resolved
synchon
synchon reviewed Mar 12, 2022
View reviewed changes
src/cobra/core/reaction.py Outdated Show resolved Hide resolved
synchon
synchon reviewed Mar 12, 2022
View reviewed changes
src/cobra/core/reaction.py Outdated Show resolved Hide resolved
synchon
synchon reviewed Mar 12, 2022
View reviewed changes
src/cobra/core/reaction.py Outdated Show resolved Hide resolved
synchon
synchon reviewed Mar 12, 2022
View reviewed changes
src/cobra/core/reaction.py Outdated Show resolved Hide resolved
synchon
synchon reviewed Mar 12, 2022
View reviewed changes
src/cobra/core/reaction.py Outdated Show resolved Hide resolved
synchon
synchon requested changes Mar 12, 2022
View reviewed changes
Copy link
Member

@synchon synchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more changes.

@synchon
Copy link
Member

synchon commented Mar 12, 2022

Thank you for your contribution!

@synchon synchon merged commit 7d95a4a into opencobra:devel Mar 12, 2022
@Midnighter
Copy link
Member

I don't follow exactly why you made those changes in the last commit.

@akaviaLab
Copy link
Contributor Author

Hi @Midnighter - The fist change is based on the conversation linked in #1171 (comment), where I understood @synchon would like these last changes to happen.
The change to err is because my linter was complaining that it was not used.
The third change is just line formatting.

@Midnighter
Copy link
Member

That makes sense. Thank you.

@akaviaLab akaviaLab deleted the refactor/core_reaction branch April 25, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@synchon synchon synchon approved these changes

@Midnighter Midnighter Midnighter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@akaviaLab @codecov-commenter @synchon @Midnighter