Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid sympy bug in ast_parser #20

Closed
wants to merge 4 commits into from
Closed

avoid sympy bug in ast_parser #20

wants to merge 4 commits into from

Conversation

arabidopsis
Copy link

Currently sympy has a bug that means that its ast_parser won't work on
pythons >= 3.5.

Also the parser will not work with gene IDs that have splice variants (i.e. they have a '.').

Solution: use cobra's own parse_gpr and then transform to a sympy expression using a NodeTransformer.

@Midnighter
Copy link
Member

Hi, thank you for answering on #19 and making this PR. The code that you're introducing looks solid to me. It could do with a docstring on the Transform class which just summarizes the intention in one line.

I'm happy to merge this now but please be aware that we haven't actively developed the driven code in a while. We will do so, however, until the middle of the year and also release it properly on PyPI.

@codecov-io
Copy link

codecov-io commented Mar 26, 2019

Codecov Report

Merging #20 into devel will decrease coverage by 8.78%.
The diff coverage is 27.27%.

Impacted file tree graph

@@            Coverage Diff            @@
##           devel      #20      +/-   ##
=========================================
- Coverage     35%   26.22%   -8.79%     
=========================================
  Files         23       23              
  Lines        677      694      +17     
=========================================
- Hits         237      182      -55     
- Misses       440      512      +72
Impacted Files Coverage Δ
src/driven/data_sets/expression_profile.py 46.06% <27.27%> (-11.7%) ⬇️
src/driven/omics/imat.py 17.64% <0%> (-79.42%) ⬇️
src/driven/omics/gimme.py 25% <0%> (-70.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74708ad...e088cbe. Read the comment docs.

@arabidopsis arabidopsis closed this by deleting the head repository May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants