Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find* cmake files installation path variable #126

Closed
smigad opened this issue Aug 22, 2018 · 4 comments
Closed

Find* cmake files installation path variable #126

smigad opened this issue Aug 22, 2018 · 4 comments
Labels
bug good first issue Good for newcomers

Comments

@smigad
Copy link
Member

smigad commented Aug 22, 2018

currently it's installed to DATADIR/cmake but it's better to use CMAKE_INSTALL_PREFIX/cmake because during compiling the intended data path and the installation path may be different. when building packages and crosscompiling this is a problem. I think it's the entire point of having CONFDIR and DATADIR they're usually similar to CMAKE_INSTALL_PREFIX but they get embedded in C source files and the path is needed to be right on the target system rather than the host.

${DATADIR}/cmake/)

@smigad
Copy link
Member Author

smigad commented Aug 23, 2018

also related to this...
it's best if all cmake config files related to opencog be placed in the same place.
Assuming the default installation path is /usr/local : CogUtils's files are installed to /usr/local/lib/CogUtil/cmake/ whereas AtomSpace's are in /usr/local/lib/cmake/AtomSpace
AtomSpace's way seems much better and cogutil's should be changed to ${LIB_INSTALL_DIR}/cmake/CogUtil)

@noskill
Copy link
Contributor

noskill commented Aug 28, 2018

Currently DATADIR is used to install *.scm files, to install cmake files, it also used from c++ to load scheme and python files... So should installation path be updated for scm files too? Is it really broken during crosscompilation?

@smigad
Copy link
Member Author

smigad commented Aug 28, 2018

Actually it doesn't really break anything. It could be driven around but DATADIR path is as you said for the scheme files which makes what's done here good but the cmake files don't need to be installed to datadir. Specially after deciding where to put the cmake files, say /use/local/lib/cmake/{cogutil,atomspace,opencog} it's best if it's consistent like mentioned in the comment above

@noskill
Copy link
Contributor

noskill commented Aug 29, 2018

@Dagiopia Ok, that makes sense, i'll move cmake files to ${LIB_INSTALL_DIR}/cmake/CogUtil

noskill added a commit to noskill/cogutils that referenced this issue Aug 29, 2018
@vsbogd vsbogd assigned vsbogd and unassigned vsbogd Aug 30, 2018
vsbogd added a commit that referenced this issue Sep 4, 2018
move CogUtilConfig.cmake file to lib/cmake/CogUtil (fix for #126)
@smigad smigad closed this as completed Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants