-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Find* cmake files installation path variable #126
Comments
also related to this... |
Currently DATADIR is used to install *.scm files, to install cmake files, it also used from c++ to load scheme and python files... So should installation path be updated for scm files too? Is it really broken during crosscompilation? |
Actually it doesn't really break anything. It could be driven around but DATADIR path is as you said for the scheme files which makes what's done here good but the cmake files don't need to be installed to datadir. Specially after deciding where to put the cmake files, say /use/local/lib/cmake/{cogutil,atomspace,opencog} it's best if it's consistent like mentioned in the comment above |
@Dagiopia Ok, that makes sense, i'll move cmake files to ${LIB_INSTALL_DIR}/cmake/CogUtil |
move CogUtilConfig.cmake file to lib/cmake/CogUtil (fix for #126)
currently it's installed to DATADIR/cmake but it's better to use CMAKE_INSTALL_PREFIX/cmake because during compiling the intended data path and the installation path may be different. when building packages and crosscompiling this is a problem. I think it's the entire point of having CONFDIR and DATADIR they're usually similar to CMAKE_INSTALL_PREFIX but they get embedded in C source files and the path is needed to be right on the target system rather than the host.
cogutil/cmake/CMakeLists.txt
Line 41 in f1aced3
The text was updated successfully, but these errors were encountered: