Randgen inherit stl random generator #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is kind of a hack because there is no point having that abstract class inherit a concrete random generator. But it's clear we don't need that home made random generator structure anymore so it's a step toward getting rid of it. The advantage is that the random generator returned by the singleton randGen() can be now used in the STL distributions.
linas
added a commit
that referenced
this pull request
Jul 31, 2015
…ator Randgen inherit stl random generator
ngeiswei
added a commit
to ngeiswei/cogutil
that referenced
this pull request
Oct 5, 2018
…workflow Add as-moses to circleci workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the random generator fully relies on STL I decided to have RandGen directly inherits std::mt19937. That way one can use the generator returned by the singleton randGen() in STL distributions.
I would have preferred to have MT19937RandGen inherit std::mt19937 rather than randGen() but I couldn't because RandGen is the abstract generator class used all over in OpenCog, and as far as I can tell there is no abstract STL generator one could use for that.
The next step would be to get rid of RandGen and MT19937RandGen, only keep rangGen() that would return an std::mt19937 generator (or any STL generator), but that involves changing the all callers. Maybe that's not worth it. The most important is that we can now use STL distributions.