Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add bootz proto #1

Merged
merged 1 commit into from
May 30, 2023
Merged

add bootz proto #1

merged 1 commit into from
May 30, 2023

Conversation

marcushines
Copy link
Contributor

No description provided.

@marcushines marcushines force-pushed the hines branch 3 times, most recently from b6c2da5 to 539bbb5 Compare May 22, 2023 21:38
@marcushines marcushines requested a review from dplore May 22, 2023 22:54
dplore
dplore reviewed May 22, 2023
View reviewed changes
Copy link
Member

@dplore dplore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments

proto/bootz.proto Outdated Show resolved Hide resolved
proto/bootz.proto Outdated Show resolved Hide resolved
proto/bootz.proto Outdated Show resolved Hide resolved
proto/bootz.proto Outdated Show resolved Hide resolved
proto/bootz.proto Show resolved Hide resolved
proto/bootz.proto Show resolved Hide resolved
@marcushines marcushines force-pushed the hines branch 8 times, most recently from 763e218 to f13afbb Compare May 23, 2023 14:24
@marcushines marcushines requested a review from dplore May 23, 2023 15:50
rnhaddad
rnhaddad reviewed May 23, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@marcushines marcushines force-pushed the hines branch 2 times, most recently from 692ad0c to 19beba6 Compare May 24, 2023 20:25
dplore
dplore requested changes May 25, 2023
View reviewed changes
Copy link
Member

@dplore dplore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provided suggestion on ControlCardState

@marcushines marcushines requested a review from dplore May 30, 2023 22:03
dplore
dplore reviewed May 30, 2023
View reviewed changes
Copy link
Member

@dplore dplore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcushines marcushines merged commit 6b8768f into main May 30, 2023
@marcushines marcushines deleted the hines branch May 31, 2023 19:38
mojiiba pushed a commit to mojiiba/bootz that referenced this pull request Aug 16, 2023
@marcushines
Merge pull request openconfig#1 from openconfig/hines
64e48ad 
add bootz proto
mojiiba pushed a commit to mojiiba/bootz that referenced this pull request Aug 16, 2023
@kjahed
Merge pull request openconfig#1 from B4Test/kjahed/dhcp
10b29ad 
dhcp v4 server
mojiiba pushed a commit to mojiiba/bootz that referenced this pull request Aug 16, 2023
@kjahed
Merge pull request openconfig#1 from B4Test/kjahed/dhcp
ae7d414 
dhcp v4 server
gmacf pushed a commit that referenced this pull request Sep 27, 2023
@melzhan
Merge pull request #1 from melzhan/lint
e2072d6 
fix another lint error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnhaddad rnhaddad rnhaddad left review comments

@vijaysgr vijaysgr vijaysgr left review comments

@dplore dplore dplore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marcushines @dplore @rnhaddad @vijaysgr