Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bootz proto #1

Merged
merged 1 commit into from
May 30, 2023
Merged

add bootz proto #1

merged 1 commit into from
May 30, 2023

Conversation

marcushines
Copy link
Contributor

No description provided.

@marcushines marcushines force-pushed the hines branch 3 times, most recently from b6c2da5 to 539bbb5 Compare May 22, 2023 21:38
@marcushines marcushines requested a review from dplore May 22, 2023 22:54
Copy link
Member

@dplore dplore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments

proto/bootz.proto Outdated Show resolved Hide resolved
proto/bootz.proto Outdated Show resolved Hide resolved
proto/bootz.proto Outdated Show resolved Hide resolved
proto/bootz.proto Outdated Show resolved Hide resolved
proto/bootz.proto Show resolved Hide resolved
proto/bootz.proto Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@marcushines marcushines force-pushed the hines branch 2 times, most recently from 692ad0c to 19beba6 Compare May 24, 2023 20:25
Copy link
Member

@dplore dplore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provided suggestion on ControlCardState

Copy link
Member

@dplore dplore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcushines marcushines merged commit 6b8768f into main May 30, 2023
@marcushines marcushines deleted the hines branch May 31, 2023 19:38
mojiiba pushed a commit to mojiiba/bootz that referenced this pull request Aug 16, 2023
mojiiba pushed a commit to mojiiba/bootz that referenced this pull request Aug 16, 2023
mojiiba pushed a commit to mojiiba/bootz that referenced this pull request Aug 16, 2023
gmacf pushed a commit that referenced this pull request Sep 27, 2023
fix another lint error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants