[gNMI-1.11, RT-5.1/3] - add InterfaceCountersUpdateDelayed deviation for CISCO #2805

kjahed · 2024-03-13T23:26:26Z

CISCO interface counters telemetry does not reflect the latest value. This PR adds InterfaceCountersUpdateDelayed and modify gNMI-1.10, gNMI-1.11, RT-5.1, and RT-5.3 to wait until the counters are updated (for a max timeout) when activated.

In addition, for gNMI-1.10, modify verifyChassisIsAncestor to ignore ancestors with no type. This is similar to PR #2808 for gNMI-1.4.

OpenConfigBot · 2024-03-13T23:26:48Z

Pull Request Functional Test Report for #2805 / `18259fb`

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		RT-5.3: Aggregate Balancing RT-5.1: Singleton Interface gNMI-1.11: Telemetry: Interface Packet Counters
Cisco 8000E		RT-5.3: Aggregate Balancing RT-5.1: Singleton Interface gNMI-1.11: Telemetry: Interface Packet Counters
Cisco XRd		RT-5.3: Aggregate Balancing RT-5.1: Singleton Interface gNMI-1.11: Telemetry: Interface Packet Counters
Juniper ncPTX		RT-5.3: Aggregate Balancing RT-5.1: Singleton Interface gNMI-1.11: Telemetry: Interface Packet Counters
Nokia SR Linux		RT-5.3: Aggregate Balancing RT-5.1: Singleton Interface gNMI-1.11: Telemetry: Interface Packet Counters
Openconfig Lemming		RT-5.3: Aggregate Balancing RT-5.1: Singleton Interface gNMI-1.11: Telemetry: Interface Packet Counters

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		RT-5.3: Aggregate Balancing RT-5.1: Singleton Interface gNMI-1.11: Telemetry: Interface Packet Counters
Cisco 8808		RT-5.3: Aggregate Balancing RT-5.1: Singleton Interface gNMI-1.11: Telemetry: Interface Packet Counters
Juniper PTX10008		RT-5.3: Aggregate Balancing RT-5.1: Singleton Interface gNMI-1.11: Telemetry: Interface Packet Counters
Nokia 7250 IXR-10e		RT-5.3: Aggregate Balancing RT-5.1: Singleton Interface gNMI-1.11: Telemetry: Interface Packet Counters

Help

LimeHat · 2024-03-14T00:34:33Z

feature/gnmi/otg_tests/telemetry_basic_check_test/telemetry_basic_check_test.go

-	if typeGot != portType {
+	typeGotV := gnmi.Lookup(t, dut, gnmi.OC().Component(val).Type().State())
+	typeGot, present := typeGotV.Val()
+	if present && typeGot != portType {


This change was not included in the PR description / not part of the deviation, it appears

Thanks. Reverted.

LimeHat · 2024-03-14T00:34:59Z

feature/gnmi/otg_tests/telemetry_basic_check_test/telemetry_basic_check_test.go

-		if got == chassisType {
+		gotV := gnmi.Lookup(t, dut, gnmi.OC().Component(val).Type().State())
+		got, present := gotV.Val()
+		if present && got == chassisType {


This change was not included in the PR description / not part of the deviation, it appears

Thanks. Updated the PR description.

coveralls · 2024-03-14T19:43:22Z

Pull Request Test Coverage Report for Build 11155885763

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 55.268%

Totals
Change from base Build 11155053907:	0.0%
Covered Lines:	1983
Relevant Lines:	3588

💛 - Coveralls

AmrNJ · 2024-03-25T08:04:20Z

@kjahed Please can you resolve the conflicts?

AmrNJ

LGTM, Please resolve the conflicts to merge

kjahed · 2024-06-12T02:25:58Z

LGTM, Please resolve the conflicts to merge

@AmrNJ done.

AmrNJ · 2024-06-27T16:38:19Z

@kjahed It still has conflicts and readme check fails. Please can you fix it?

arvbaska1 · 2024-09-19T16:01:38Z

Merge conflicts are fixed, the Readme check fails due to some issue in test-requirements-template.md
https://github.com/openconfig/featureprofiles/actions/runs/10944362833/job/30386029201?pr=2805

Local check passes for this test
go run ./tools/validate_readme_spec/validate_readme_spec.go --feature-dir feature/interface/aggregate/otg_tests/balancing_test/README.md
%

ram-mac

LGTM

wait for counters update

a787cad

kjahed requested review from a team as code owners March 13, 2024 23:26

kjahed requested a review from michaelore March 13, 2024 23:26

kjahed added the cisco-pr label Mar 13, 2024

LimeHat reviewed Mar 14, 2024

View reviewed changes

kjahed added 2 commits March 14, 2024 15:26

revert some changes

755d375

Merge remote-tracking branch 'public/main' into kjahed/gnmi-1.11

9062bc7

kjahed added 3 commits April 4, 2024 19:31

bug fix

b64e91b

Merge remote-tracking branch 'public/main' into kjahed/gnmi-1.11

7a2f18d

go fmt

7632be8

AmrNJ previously approved these changes Jun 11, 2024

View reviewed changes

Merge remote-tracking branch 'public/main' into kjahed/gnmi-1.11

9079d46

kjahed dismissed AmrNJ’s stale review via 9079d46 June 12, 2024 02:05

AmrNJ self-assigned this Jun 26, 2024

AmrNJ removed their assignment Jul 8, 2024

kjahed and others added 3 commits September 19, 2024 09:54

Merge remote-tracking branch 'public/main' into kjahed/gnmi-1.11

4cf59d6

fix readme check

e8698db

readme check change

9539a2e

kjahed added 2 commits September 24, 2024 12:29

restore gnmi-1.10

0df43b9

restore gnmi-1.10

87b994f

kjahed changed the title ~~[gNMI-1.10/11, RT-5.1/3] - add InterfaceCountersUpdateDelayed deviation for CISCO~~ [gNMI-11, RT-5.1/3] - add InterfaceCountersUpdateDelayed deviation for CISCO Sep 24, 2024

kjahed changed the title ~~[gNMI-11, RT-5.1/3] - add InterfaceCountersUpdateDelayed deviation for CISCO~~ [gNMI-1.11, RT-5.1/3] - add InterfaceCountersUpdateDelayed deviation for CISCO Sep 24, 2024

Merge remote-tracking branch 'public/main' into kjahed/gnmi-1.11

eda093e

kjahed requested a review from ram-mac as a code owner September 26, 2024 21:08

arvbaska1 and others added 8 commits September 26, 2024 17:51

remove /tmp

b0bf67c

remove tmp path

39606b1

fix readme

535648f

fix indentation

eaca9aa

fix readme

5863343

Merge branch 'main' into kjahed/gnmi-1.11

ef6651d

Merge branch 'main' into kjahed/gnmi-1.11

4d02b38

merge main

18259fb

ram-mac approved these changes Oct 3, 2024

View reviewed changes

ram-mac merged commit 43e3890 into openconfig:main Oct 3, 2024
13 checks passed

kjahed mentioned this pull request Oct 22, 2024

[gNMI-1.10] add InterfaceCountersUpdateDelayed deviation #3536

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[gNMI-1.11, RT-5.1/3] - add InterfaceCountersUpdateDelayed deviation for CISCO #2805

[gNMI-1.11, RT-5.1/3] - add InterfaceCountersUpdateDelayed deviation for CISCO #2805

kjahed commented Mar 13, 2024 •

edited

Loading

OpenConfigBot commented Mar 13, 2024 •

edited

Loading

LimeHat Mar 14, 2024

kjahed Mar 14, 2024

LimeHat Mar 14, 2024

kjahed Mar 14, 2024

coveralls commented Mar 14, 2024 •

edited

Loading

AmrNJ commented Mar 25, 2024

AmrNJ left a comment

kjahed commented Jun 12, 2024

AmrNJ commented Jun 27, 2024

arvbaska1 commented Sep 19, 2024

ram-mac left a comment

[gNMI-1.11, RT-5.1/3] - add InterfaceCountersUpdateDelayed deviation for CISCO #2805

[gNMI-1.11, RT-5.1/3] - add InterfaceCountersUpdateDelayed deviation for CISCO #2805

Conversation

kjahed commented Mar 13, 2024 • edited Loading

OpenConfigBot commented Mar 13, 2024 • edited Loading

Pull Request Functional Test Report for #2805 / 18259fb

Virtual Devices

Hardware Devices

LimeHat Mar 14, 2024

Choose a reason for hiding this comment

kjahed Mar 14, 2024

Choose a reason for hiding this comment

LimeHat Mar 14, 2024

Choose a reason for hiding this comment

kjahed Mar 14, 2024

Choose a reason for hiding this comment

coveralls commented Mar 14, 2024 • edited Loading

Pull Request Test Coverage Report for Build 11155885763

Details

💛 - Coveralls

AmrNJ commented Mar 25, 2024

AmrNJ left a comment

Choose a reason for hiding this comment

kjahed commented Jun 12, 2024

AmrNJ commented Jun 27, 2024

arvbaska1 commented Sep 19, 2024

ram-mac left a comment

Choose a reason for hiding this comment

kjahed commented Mar 13, 2024 •

edited

Loading

OpenConfigBot commented Mar 13, 2024 •

edited

Loading

Pull Request Functional Test Report for #2805 / `18259fb`

coveralls commented Mar 14, 2024 •

edited

Loading