Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regenerate .pb.go files with protoc-gen-go v1.1.0 #24

Closed
aaronbee opened this issue May 18, 2018 · 1 comment
Closed

Regenerate .pb.go files with protoc-gen-go v1.1.0 #24

aaronbee opened this issue May 18, 2018 · 1 comment

Comments

@aaronbee
Copy link

v1.1.0 of golang/protobuf has been released and is "1.3x to 2.1x faster". To take advantage of some of these improvements requires regenerating the .pb.go files with the latest version of protoc-gen-go.
robshakir added a commit that referenced this issue May 30, 2018
@robshakir
Regenerate *.pb.go using golang/protobuf HEAD.
0bf1f6c 
This PR checks in regenerated pb.go files for the protos within
the gNMI repository. This uses today's HEAD@master in the golang/gnmi
repository (commit SHA 3a3da3a4e26776cc22a79ef46d5d58477532dede), which
incorporates the v1.10 release
(https://github.com/golang/protobuf/releases/tag/v1.1.0).

The regenerated files therefore include the optimisations for both
Marshal and Unmarshal that are included in the updated proto files.

Fixes #24.
@robshakir
Copy link
Contributor

Thanks Aaron -- PR on its way.

@robshakir robshakir mentioned this issue May 30, 2018
Merged
@gcsl gcsl closed this as completed in #26 May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aaronbee @robshakir