Initial version of test.proto #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aghaffarkhah
reviewed
Jul 2, 2018
test/test.proto
Outdated
| // This gNOI service is a collection of operational RPC's that allow for the | ||
| // testing of a target by triggering events that otherwise would be difficult | ||
| // to trigger without sophisticated test-bed. | ||
| service StepExecutionService { |
There was a problem hiding this comment.
Lets have only one service in this file which targets testing. So please pick a generic name like "Test" or something. This name is a bit non generic.
test/test.proto
Outdated
| // messages. Execution of each step is confirmed by transmitting back a | ||
| // StepExecutionResult message. | ||
| rpc ExecuteSteps(stream StepExecutionRequest) | ||
| returns (stream StepExecutionResult); |
There was a problem hiding this comment.
Please use the format
rpc Foo (stream FooRequest) return (stream FooResponse)
test/test.proto
Outdated
| // ExecuteSteps executes steps specified in the stream of StepExecutionRequest | ||
| // messages. Execution of each step is confirmed by transmitting back a | ||
| // StepExecutionResult message. | ||
| rpc ExecuteSteps(stream StepExecutionRequest) |
There was a problem hiding this comment.
Why not just call this Execute and messages ExecuteRequet and ExecuteResponse? Seems more generic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.