Add missing enums to gnsi.accounting #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Might not be practical to account every p4rt rpc due to volume, but that is and administrator and start/stop records would be reasonsable. Add gnsi.accounting.CommandService.CmdServiceType values for HTTP (Web UIs), RESTCONF, and NETCONF. Examples sources for these: https://datatracker.ietf.org/doc/html/rfc2865#section-5.6 https://datatracker.ietf.org/doc/html/rfc2865#section-5.15 also see https://www.iana.org/assignments/radius-types/radius-types.xhtml
morrowc
approved these changes
Jul 15, 2023
earies
reviewed
Jul 16, 2023
morrowc
reviewed
Jul 16, 2023
|
Sun, Jul 16, 2023 at 04:02:30PM -0700, Chris Morrow:
@morrowc commented on this pull request.
fix up the count... from 4 to 5.
Ach, sorry about that. I often forget to increment the field number. Thanks
for fixing it.
|
morrowc
approved these changes
Jul 21, 2023
morrowc
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.