Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable nodeport auto allocation #544

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Disable nodeport auto allocation #544

merged 1 commit into from
Jul 8, 2024

Conversation

alexmasi
Copy link
Contributor

@alexmasi alexmasi commented Jul 2, 2024

Do not allocate a NodePort for this LoadBalancer. MetalLB or the equivalent load balancer should handle exposing this service. Large topologies may try to allocate more NodePorts than are supported in default clusters.

https://kubernetes.io/docs/concepts/services-networking/service/#load-balancer-nodeport-allocation

https://kubernetes.io/docs/concepts/services-networking/service/#type-nodeport (by default <3k services are allowed, with nodes having ~5 services this limits topo size)

@alexmasi alexmasi requested a review from marcushines July 2, 2024 21:56
@coveralls
Copy link

coveralls commented Jul 2, 2024

Pull Request Test Coverage Report for Build 9768489652

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 65.241%

Totals Coverage Status
Change from base Build 9765987846: 0.03%
Covered Lines: 4653
Relevant Lines: 7132

💛 - Coveralls

@alexmasi alexmasi merged commit c4870fe into main Jul 8, 2024
9 checks passed
@alexmasi alexmasi deleted the nodeport branch July 8, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants