Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require Target when doing gNMI requests #291

Merged
merged 4 commits into from
Oct 9, 2023
Merged

Conversation

wenovus
Copy link
Contributor

@wenovus wenovus commented Oct 9, 2023

Resolves #263

@wenovus wenovus requested a review from DanG100 October 9, 2023 20:13
@DanG100
Copy link
Collaborator

DanG100 commented Oct 9, 2023

Is there a TODO to remove all the places in the lemming that set a target?

@wenovus
Copy link
Contributor Author

wenovus commented Oct 9, 2023

Is there a TODO to remove all the places in the lemming that set a target?

Thanks for catching this. There are indeed a lot of places the code that now unnecessarily take target as an argument or otherwise assume that gNMI requires populating target. I'll create a task for clean-up.

@wenovus wenovus merged commit 5523fd3 into main Oct 9, 2023
6 of 9 checks passed
@wenovus wenovus deleted the autopop-target branch October 9, 2023 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subscribe() requires a target while the spec says it shouldn't
2 participants