Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests and fix major version comment #95

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Add tests and fix major version comment #95

merged 2 commits into from
Nov 30, 2023

Conversation

wenovus
Copy link
Contributor

@wenovus wenovus commented Nov 30, 2023 •
edited
Loading

The logic for "No major changes in ..." was wrong so this comment wasn't showing up.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 30, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7050556035

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.6%) to 55.145%
Totals Coverage Status
Change from base Build 6935616849: 0.6%
Covered Lines: 954
Relevant Lines: 1730
💛 - Coveralls

@wenovus wenovus mentioned this pull request Nov 30, 2023
Closed
robshakir
robshakir previously approved these changes Nov 30, 2023
View reviewed changes
@wenovus wenovus merged commit f533fdd into master Nov 30, 2023
7 checks passed
@wenovus wenovus deleted the fix-major-version-comment branch November 30, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dplore dplore dplore approved these changes

@robshakir robshakir Awaiting requested review from robshakir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wenovus @robshakir @dplore