Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug where simple union enums causes panic within ygot.Diff. #461

Merged
merged 1 commit into from
Sep 30, 2020
Merged

Fix bug where simple union enums causes panic within ygot.Diff. #461

merged 1 commit into from
Sep 30, 2020

Conversation

wenovus
Copy link
Collaborator

@wenovus wenovus commented Sep 30, 2020

The enum value needs to be extracted from the union interface first. This is due to missing test coverage, which is now added.

@googlebot googlebot added the cla: yes This PR author has signed the CLA label Sep 30, 2020
@coveralls
Copy link

Coverage Status

Coverage increased (+0.005%) to 90.528% when pulling e38789d on new-union-diff-fix into 003238b on master.

@wenovus wenovus merged commit fc02f43 into master Sep 30, 2020
@wenovus wenovus deleted the new-union-diff-fix branch September 30, 2020 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg-dennis greg-dennis greg-dennis approved these changes

@robshakir robshakir Awaiting requested review from robshakir

Assignees
No one assigned
Labels
cla: yes This PR author has signed the CLA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wenovus @coveralls @greg-dennis @googlebot