Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete StoreRawSchema from GeneratorConfig since it's not being used #705

Merged
merged 3 commits into from
Jun 9, 2022
Merged

Delete StoreRawSchema from GeneratorConfig since it's not being used #705

merged 3 commits into from
Jun 9, 2022

Commits on Jun 9, 2022

  1. Delete StoreRawSchema from GeneratorConfig since it's not being used 

    I don't see the value of why we need this flag: is it to save memory?
For `exampleoc` this variable took 27MB, a negligible amount.
    @wenovus
    wenovus committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    f0d5136 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'ci-check-generate' into delete-StoreRawSchema

    @wenovus
    wenovus committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    e27d9ba View commit details
    Browse the repository at this point in the history

  3. Reorganize Code Generation flags and Delete ygen.GeneratorConfig (#706 

    )

* ygen now only has `IROptions`.
* `CodeGenerator` in gogen/protogen now carry IROptions and their language-specific post-IR generation options.
* Code generation specific flags that are not used during IR generation are moved to `gogen` and `protogen`, duplicating if used by both (e.g. CallerName).
* `SkipEnumDeduplication` is moved from ParseOptions to TransformationOptions.
    @wenovus
    wenovus authored Jun 9, 2022
    Configuration menu
    Copy the full SHA
    c2b34d5 View commit details
    Browse the repository at this point in the history