Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mini update 6: describe pull workflow #166

Merged
merged 36 commits into from
Jul 29, 2020

Conversation

pmengelbert
Copy link
Contributor

jdolitsky and others added 4 commits May 20, 2020 15:21
Related to opencontainers#126

The following sections have been removed:
- Changes
- Historical Context (already in reorg)
- Overview / Listing Repositories (unused catalog API)

The following sections have been moved into commented reorg:
- Notational Conventions ---> Definitions / Document Language
- Overview / Errors ---> HTTP API / Error Codes
- Overview / API Version Check ---> Conformance / Workflow Categories / Pull
- Overview / Pulling An Image ---> Conformance / Workflow Categories / Pull
- Overview / Pushing An Image ---> Conformance / Workflow Categories / Push
- Overview / Listing Image Tags ---> Conformance / Workflow Categories / Content Discovery
- Overview / Deleting an Image ---> Conformance / Workflow Categories / Content Management
- Detail / Errors ---> HTTP API / Error Codes

Signed-off-by: Josh Dolitsky <393494+jdolitsky@users.noreply.github.com>
Fill in the definitions section, introducing several
terms and defintions which will serve as reference for
the rest of the document.

Also moved the "notational conventions" section into
this section, removing any language that seemed
unnecessary or related to compliance (which will be
covered in the conformance section).

Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
Fill in conformance section, adding minimum requirements
stating that all compliant registries must at least support Pull.

Added a section regarding certification, linking to the
opencontainers/oci-conformance repo.

For the workflow sections, intentionally left blank, and will
be added in a follow-up PR.

Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
Signed-off-by: Peter Engelbert <pmengelbert@gmail.com>

`<name>` is the namespace of the repository, and `<digest>` being the blob's digest.

A GET request to an existing blob URL MUST provide the expected blob, with a reponse code that MUST be `200 OK`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MUST here => minimum requirement! nice.

jdolitsky and others added 15 commits June 26, 2020 17:20
…-spec into HEAD

Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
…-spec into HEAD

Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
This is a new table of contents for the spec, designed to
add simplicity and organization.

Existing content will later be moved into one of these sections,
or removed entirely if considered superfluous.

Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
Fill in the overview section, including new introduction
referring to "content" (vs. just container images).

Move historical context section underneath overview.

Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
Fill in the definitions section, introducing several
terms and defintions which will serve as reference for
the rest of the document.

Also moved the "notational conventions" section into
this section, removing any language that seemed
unnecessary or related to compliance (which will be
covered in the conformance section).

Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
Fill in conformance section, adding minimum requirements
stating that all compliant registries must at least support Pull.

Added a section regarding certification, linking to the
opencontainers/oci-conformance repo.

For the workflow sections, intentionally left blank, and will
be added in a follow-up PR.

Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
Fill in conformance section, adding minimum requirements
stating that all compliant registries must at least support Pull.

Added a section regarding certification, linking to the
opencontainers/oci-conformance repo.

For the workflow sections, intentionally left blank, and will
be added in a follow-up PR.

Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
Signed-off-by: Peter Engelbert <pmengelbert@gmail.com>
…-spec into mini-update-6

Signed-off-by: Peter Engelbert <pmengelbert@gmail.com>
…-spec into mini-update-6

Signed-off-by: Peter Engelbert <pmengelbert@gmail.com>
…nto mini-update-4

Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
@jdolitsky jdolitsky mentioned this pull request Jun 29, 2020
14 tasks
Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
…-spec into HEAD

Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
…to HEAD

Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
…-spec into mini-update-6

Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
spec.md Outdated Show resolved Hide resolved
Signed-off-by: Peter Engelbert <pmengelbert@gmail.com>
Copy link
Member

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdolitsky jdolitsky merged commit f8d87fb into opencontainers:reorg Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants