-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mini update 6: describe pull workflow #166
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to opencontainers#126 The following sections have been removed: - Changes - Historical Context (already in reorg) - Overview / Listing Repositories (unused catalog API) The following sections have been moved into commented reorg: - Notational Conventions ---> Definitions / Document Language - Overview / Errors ---> HTTP API / Error Codes - Overview / API Version Check ---> Conformance / Workflow Categories / Pull - Overview / Pulling An Image ---> Conformance / Workflow Categories / Pull - Overview / Pushing An Image ---> Conformance / Workflow Categories / Push - Overview / Listing Image Tags ---> Conformance / Workflow Categories / Content Discovery - Overview / Deleting an Image ---> Conformance / Workflow Categories / Content Management - Detail / Errors ---> HTTP API / Error Codes Signed-off-by: Josh Dolitsky <393494+jdolitsky@users.noreply.github.com>
Fill in the definitions section, introducing several terms and defintions which will serve as reference for the rest of the document. Also moved the "notational conventions" section into this section, removing any language that seemed unnecessary or related to compliance (which will be covered in the conformance section). Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
Fill in conformance section, adding minimum requirements stating that all compliant registries must at least support Pull. Added a section regarding certification, linking to the opencontainers/oci-conformance repo. For the workflow sections, intentionally left blank, and will be added in a follow-up PR. Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
Signed-off-by: Peter Engelbert <pmengelbert@gmail.com>
rchincha
reviewed
Jun 19, 2020
|
||
`<name>` is the namespace of the repository, and `<digest>` being the blob's digest. | ||
|
||
A GET request to an existing blob URL MUST provide the expected blob, with a reponse code that MUST be `200 OK`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MUST here => minimum requirement! nice.
…-spec into HEAD Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
…-spec into HEAD Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
This is a new table of contents for the spec, designed to add simplicity and organization. Existing content will later be moved into one of these sections, or removed entirely if considered superfluous. Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
Fill in the overview section, including new introduction referring to "content" (vs. just container images). Move historical context section underneath overview. Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
Fill in the definitions section, introducing several terms and defintions which will serve as reference for the rest of the document. Also moved the "notational conventions" section into this section, removing any language that seemed unnecessary or related to compliance (which will be covered in the conformance section). Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
Fill in conformance section, adding minimum requirements stating that all compliant registries must at least support Pull. Added a section regarding certification, linking to the opencontainers/oci-conformance repo. For the workflow sections, intentionally left blank, and will be added in a follow-up PR. Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
Fill in conformance section, adding minimum requirements stating that all compliant registries must at least support Pull. Added a section regarding certification, linking to the opencontainers/oci-conformance repo. For the workflow sections, intentionally left blank, and will be added in a follow-up PR. Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
Signed-off-by: Peter Engelbert <pmengelbert@gmail.com>
…-spec into mini-update-6 Signed-off-by: Peter Engelbert <pmengelbert@gmail.com>
…-spec into mini-update-6 Signed-off-by: Peter Engelbert <pmengelbert@gmail.com>
pmengelbert
force-pushed
the
mini-update-6
branch
from
June 29, 2020 18:52
8438dee
to
07e23a1
Compare
…nto mini-update-4 Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
14 tasks
Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
…-spec into HEAD Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
…to HEAD Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
…-spec into mini-update-6 Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
jdolitsky
approved these changes
Jul 21, 2020
jdolitsky
requested changes
Jul 22, 2020
Signed-off-by: Peter Engelbert <pmengelbert@gmail.com>
dmcgowan
approved these changes
Jul 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jdolitsky
approved these changes
Jul 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
builds upon PR #162 .
Here is the diff between this commit and PR #162:
https://github.com/bloodorangeio/distribution-spec/compare/mini-update-5...bloodorangeio:mini-update-6?expand=1