Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cgroup2: Revert "CreateCgroupPath: only enable needed controllers" #2367

Closed
AkihiroSuda opened this issue Apr 30, 2020 · 3 comments
Closed

Comments

@AkihiroSuda
Copy link
Member

CreateCgroupPath: only enable needed controllers (4b4bc99) seems problematic toward supporting nested containers. (#2356)

As many controller s as possible should be always enabled.

cc @kolyshkin

@AkihiroSuda
Copy link
Member Author

@kolyshkin WDYT?

@kolyshkin
Copy link
Contributor

Enabling a controller should negatively affect performance (since some accounting for the resource(s) controlled are to be done by the kernel) -- even in the case no limits are set.

So, this is a trade-off between best performance and versatility. Ideally, I'd like it to be configurable (i.e. there should be a way to just enable a controller but do not set any limits, which is currently impossible).

Until we have this ability, either way is fine with me (all controllers or on-demand). Since we used to have all controllers, let's do that.

@AkihiroSuda
Copy link
Member Author

resolved in #2395

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants