Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Valid IDs #635

Closed
ip1981 opened this issue Mar 11, 2016 · 2 comments
Closed

Valid IDs #635

ip1981 opened this issue Mar 11, 2016 · 2 comments

Comments

@ip1981
Copy link

ip1981 commented Mar 11, 2016

Why are IDs restricted by this pattern?

idRegex = regexp.MustCompile(`^[\w_-]+$`)

https://github.com/opencontainers/runc/blob/master/libcontainer/factory_linux.go#L29
@crosbymichael
Copy link
Member

It is for valid filepath names because the container id needs to be written to disk in something like /run to store state.

@ip1981
Copy link
Author

ip1981 commented Mar 14, 2016

File names can include a way more other characters. I fail to see reasons for existing restrictions. foo.com is a valid file name, but not a valid id. Why?

@crosbymichael crosbymichael reopened this Mar 14, 2016
@rajasec rajasec mentioned this issue Mar 15, 2016
Merged
@wking wking mentioned this issue Jul 22, 2016
Closed
@thaJeztah thaJeztah mentioned this issue Sep 3, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ip1981 @crosbymichael