Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: add go 1.15, rm unsupported versions #115

Merged
merged 1 commit into from
Aug 18, 2020

Conversation

kolyshkin
Copy link
Collaborator

Since go 1.15 is out, go 1.13 is no longer supported.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@rhatdan
Copy link
Collaborator

rhatdan commented Aug 17, 2020

LGTM
@mrunalp @saschagrunert @thaJeztah @vrothberg PTAL

Approved with PullApprove

Copy link
Collaborator

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis changes LGTM, but let's change the go.mod version too.

@thaJeztah
Copy link
Member

Would it be possible to keep 1.13 for a short while? Go 1.14 has proven to be a problematic release, and while downstream projects will upgrade to Go 1.15 (which fixes most of the issues with Go 1.14), not all project have migrated yet (and may wait for the first patch release of Go 1.15 in case there's regressions).

change the go.mod version too.

IIRC, setting a higher go version in go.mod will result in consumers of the package to no longer being able to build, correct? If so, I wonder if we should be somewhat conservative there as well, and not restrict older versions (unless we have specific reasons to not allow other versions).

@saschagrunert
Copy link
Contributor

change the go.mod version too.

IIRC, setting a higher go version in go.mod will result in consumers of the package to no longer being able to build, correct? If so, I wonder if we should be somewhat conservative there as well, and not restrict older versions (unless we have specific reasons to not allow other versions).

I think the version is more an indicator to the module system if there are some changes needed to the vendored sources or go.mod/sum. It does not restrict the build as far as I know,.

@thaJeztah
Copy link
Member

I think the version is more an indicator to the module system if there are some changes needed to the vendored sources or go.mod/sum. It does not restrict the build as far as I know,.

Ah, looks like that may have been a bug in Go < 1.11.4 golang/go#30446 (comment) (see golang/go@e32203f)

I wonder if they start enforcing at some point though (same as they started enforcing the import paths for Go 1.13 and up 🤔)

@rhatdan
Copy link
Collaborator

rhatdan commented Aug 18, 2020

Well if this becomes a problem we can always revert.

@rhatdan rhatdan merged commit 3946397 into opencontainers:master Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants