-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
travis: add go 1.15, rm unsupported versions #115
Conversation
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Travis changes LGTM, but let's change the go.mod version too.
Would it be possible to keep 1.13 for a short while? Go 1.14 has proven to be a problematic release, and while downstream projects will upgrade to Go 1.15 (which fixes most of the issues with Go 1.14), not all project have migrated yet (and may wait for the first patch release of Go 1.15 in case there's regressions).
IIRC, setting a higher go version in go.mod will result in consumers of the package to no longer being able to build, correct? If so, I wonder if we should be somewhat conservative there as well, and not restrict older versions (unless we have specific reasons to not allow other versions). |
I think the version is more an indicator to the module system if there are some changes needed to the vendored sources or go.mod/sum. It does not restrict the build as far as I know,. |
Ah, looks like that may have been a bug in Go < 1.11.4 golang/go#30446 (comment) (see golang/go@e32203f) I wonder if they start enforcing at some point though (same as they started enforcing the import paths for Go 1.13 and up 🤔) |
Well if this becomes a problem we can always revert. |
Since go 1.15 is out, go 1.13 is no longer supported.