-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add export option #292
Add export option #292
Conversation
redhatrises
commented
Jun 11, 2018
- Fixes Support 'export' option #267
40c4ab3
to
4039564
Compare
Codecov Report
@@ Coverage Diff @@
## master #292 +/- ##
==========================================
- Coverage 86.75% 79.51% -7.25%
==========================================
Files 32 38 +6
Lines 1012 1411 +399
==========================================
+ Hits 878 1122 +244
- Misses 116 239 +123
- Partials 18 50 +32
Continue to review full report at Codecov.
|
4039564
to
9181641
Compare
@redhatrises #291 forced a rebase of this |
- Fixes opencontrol#267
9181641
to
e937da2
Compare
} | ||
buffer.WriteString(string(bytesJSON)) | ||
|
||
// iterate over components |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
components
and standard
iterations are very similar. Could this be condensed into a for each loop?
e.g.
arrayOpenControl := [2]string{"components", "standards"}
for index,element := range arrayOpenControl{
if len(p.element) > 0 {
.... do stuff
}
}
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shawndwells this actually would probably be a separate function as it deals with more than just strings.
I was hoping to avoid code cleanup in these type of PRs because of how big they are.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tracked in #295
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. Thanks for opening the ticket to track.