Fix Export typos #305
Fix Export typos #305
Conversation
redhatrises
commented
Jun 19, 2018
redhatrises
commented
- typos were causing crashes
- typos were causing crashes
Codecov Report
@@ Coverage Diff @@
## master #305 +/- ##
=======================================
Coverage 79.25% 79.25%
=======================================
Files 38 38
Lines 1427 1427
=======================================
Hits 1131 1131
Misses 244 244
Partials 52 52
Continue to review full report at Codecov.
|
pkg/cli/export/export.go
Outdated
| @@ -49,12 +49,12 @@ func RunExport(out io.Writer, cmd *cobra.Command, args []string) error { | |||
| } | |||
|
|
|||
| // read parms | |||
| parmOpencontrols := cmd.Flag("opencontrols").Value.String() | |||
| parmDestination := cmd.Flag("destination").Value.String() | |||
| parmOpencontrols := cmd.Flag("opencontrol").Value.String() | |||
There was a problem hiding this comment.
should this be renamed to parmOpencontrol to match?
There was a problem hiding this comment.
@shawndwells doesn't have to be, but can if you want it.
There was a problem hiding this comment.
The naming should be aligned.
Was looking at how it's used:
// construct args
config := Config{
Certification: args[0],
OpencontrolDir: parmOpencontrols,
DestinationFile: parmDestination,
OutputFormat: outputFormat,
Flatten: parmFlatten,
InferKeys: parmInferKeys,
Docxtemplater: parmDocxtemplater,
KeySeparator: parmKeySeparator,
}
Should it really be called something like parmInputDir?
Minimally should be parmOpencontrol (singular) to match the command flag. parmInputDir would be more descriptive.
What do you think?
Not the most important thing in the world, but while this part of the code is being touched....
