-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] curvefs: Separate raft read and write apply queues for curvefs #2498
Merged
ilixiaocui
merged 1 commit into
opencurve:master
from
Xinlong-Chen:separate-raft-apply-queue
Jun 1, 2023
Merged
[feat] curvefs: Separate raft read and write apply queues for curvefs #2498
ilixiaocui
merged 1 commit into
opencurve:master
from
Xinlong-Chen:separate-raft-apply-queue
Jun 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xinlong-Chen
force-pushed
the
separate-raft-apply-queue
branch
3 times, most recently
from
May 23, 2023 11:06
f2e751c
to
a34222d
Compare
cicheck |
@ilixiaocui @wu-hanqing here~ please take a look, thx~ |
wu-hanqing
requested changes
May 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, squash into one commit
Xinlong-Chen
force-pushed
the
separate-raft-apply-queue
branch
2 times, most recently
from
May 25, 2023 16:05
a890f88
to
f00ba15
Compare
cicheck |
Xinlong-Chen
force-pushed
the
separate-raft-apply-queue
branch
2 times, most recently
from
May 26, 2023 04:59
6c84913
to
2234eaf
Compare
cicheck |
wu-hanqing
reviewed
May 29, 2023
curvefs/test/metaserver/copyset/concurrent_apply_queue_test.cpp
Outdated
Show resolved
Hide resolved
curvefs/test/metaserver/copyset/concurrent_apply_queue_test.cpp
Outdated
Show resolved
Hide resolved
Xinlong-Chen
force-pushed
the
separate-raft-apply-queue
branch
4 times, most recently
from
May 29, 2023 12:56
59f1970
to
12a2cd5
Compare
Signed-off-by: Xinlong-Chen <xl_chen@zju.edu.cn>
Xinlong-Chen
force-pushed
the
separate-raft-apply-queue
branch
from
May 29, 2023 12:57
12a2cd5
to
5e1dea0
Compare
cicheck |
wu-hanqing
approved these changes
May 31, 2023
@ilixiaocui please take a look, thx~ |
ilixiaocui
approved these changes
Jun 1, 2023
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: #1598
Problem Summary:
Separate raft read and write apply queues for curvefs
What is changed and how it works?
What's Changed: add raft read and write apply queues for curvefs
How it Works:
Side effects(Breaking backward compatibility? Performance regression?):
Check List