Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] curvefs: Separate raft read and write apply queues for curvefs #2498

Merged

Conversation

Xinlong-Chen
Copy link
Contributor

@Xinlong-Chen Xinlong-Chen commented May 22, 2023

What problem does this PR solve?

Issue Number: #1598

Problem Summary:
Separate raft read and write apply queues for curvefs

What is changed and how it works?

What's Changed: add raft read and write apply queues for curvefs

How it Works:

截屏2023-05-22 23 27 41

Side effects(Breaking backward compatibility? Performance regression?):

Check List

  • Relevant documentation/comments is changed or added
  • I acknowledge that all my contributions will be made under the project's license

@zhanghuidinah zhanghuidinah added the OSPP2023 开源之夏2023(https://summer-ospp.ac.cn) label May 23, 2023
@Xinlong-Chen Xinlong-Chen force-pushed the separate-raft-apply-queue branch 3 times, most recently from f2e751c to a34222d Compare May 23, 2023 11:06
@Xinlong-Chen
Copy link
Contributor Author

cicheck

@Xinlong-Chen
Copy link
Contributor Author

@ilixiaocui @wu-hanqing here~ please take a look, thx~

Copy link
Contributor

@wu-hanqing wu-hanqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, squash into one commit

curvefs/conf/metaserver.conf Outdated Show resolved Hide resolved
curvefs/src/metaserver/copyset/concurrent_apply_queue.h Outdated Show resolved Hide resolved
curvefs/src/metaserver/copyset/copyset_node.cpp Outdated Show resolved Hide resolved
curvefs/src/metaserver/copyset/concurrent_apply_queue.cpp Outdated Show resolved Hide resolved
curvefs/test/metaserver/copyset/meta_operator_test.cpp Outdated Show resolved Hide resolved
curvefs/conf/metaserver.conf Outdated Show resolved Hide resolved
curvefs/conf/metaserver.conf Outdated Show resolved Hide resolved
curvefs/src/metaserver/copyset/concurrent_apply_queue.h Outdated Show resolved Hide resolved
curvefs/src/metaserver/copyset/concurrent_apply_queue.h Outdated Show resolved Hide resolved
@Xinlong-Chen Xinlong-Chen force-pushed the separate-raft-apply-queue branch 2 times, most recently from a890f88 to f00ba15 Compare May 25, 2023 16:05
@Xinlong-Chen
Copy link
Contributor Author

cicheck

@Xinlong-Chen Xinlong-Chen force-pushed the separate-raft-apply-queue branch 2 times, most recently from 6c84913 to 2234eaf Compare May 26, 2023 04:59
@Xinlong-Chen
Copy link
Contributor Author

cicheck

@Xinlong-Chen Xinlong-Chen force-pushed the separate-raft-apply-queue branch 4 times, most recently from 59f1970 to 12a2cd5 Compare May 29, 2023 12:56
Signed-off-by: Xinlong-Chen <xl_chen@zju.edu.cn>
@Xinlong-Chen
Copy link
Contributor Author

cicheck

@Xinlong-Chen
Copy link
Contributor Author

@ilixiaocui please take a look, thx~

@ilixiaocui
Copy link
Contributor

LGTM!

@ilixiaocui ilixiaocui merged commit f1286c2 into opencurve:master Jun 1, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OSPP2023 开源之夏2023(https://summer-ospp.ac.cn)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants