[feat] tools-v2: add bs status cluster #2530

caoxianfei1 · 2023-06-13T02:11:53Z

What problem does this PR solve?

Issue Number: #xxx

Problem Summary:

What is changed and how it works?

What's Changed:

How it Works:

curve bs status cluster

The output is as follows：

Services:

ROLE	LEADER	ONLINE
etcd	10.0.0.1:23790	10.0.0.2:23790 10.0.0.3:23790
mds	10.0.0.1:6700	10.0.0.2:6700 10.0.0.3:6700
chunkserver	-	10.0.0.1:8200 10.0.0.2:8200 10.0.0.3:8200
snapshot	10.0.0.1:5555	10.0.0.2:5555 10.0.0.3:5555

Copyset:

POOLID	TOTAL	OK	WARN	ERROR
1	100	94	3	3

Space:

TYPE	USED	LEFT	RECYCLABLE	CREATED
physical	0 B	98 GiB	-	-

Cluster health is: ok

Side effects(Breaking backward compatibility? Performance regression?):

Check List

Relevant documentation/comments is changed or added
I acknowledge that all my contributions will be made under the project's license

Cyber-SiKu · 2023-06-13T06:50:04Z

cicheck

Cyber-SiKu

run fail

curve bs status cluster      
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0xec8ef8]

goroutine 1 [running]:
github.com/opencurve/curve/tools-v2/pkg/cli/command/curvebs/status/cluster.(*ClusterCommand).RunCommand(0xc0001b89a0, 0xc0004ddb00, {0x1795258, 0x0, 0x0})
        /home/******/code/curve-backup/tools-v2/pkg/cli/command/curvebs/status/cluster/cluster.go:112 +0x238

Cyber-SiKu · 2023-06-13T06:56:02Z

tools-v2/internal/error/error.go

@@ -459,6 +459,9 @@ var (
 	ErrBsListScanStatus = func() *CmdError {
 		return NewInternalCmdError(66, "list scan-status fail, err: %s")
 	}
+	ErrBsListSpaceStatus = func() *CmdError {
+		return NewInternalCmdError(66, "list space status fail, err: %s")


Suggested change

return NewInternalCmdError(66, "list space status fail, err: %s")

return NewInternalCmdError(67, "list space status fail, err: %s")

Xinlong-Chen

good job

Xinlong-Chen · 2023-06-13T07:57:33Z

tools-v2/pkg/cli/command/curvebs/list/space/space.go

@@ -187,3 +188,20 @@ func (sCmd *SpaceCommand) RunCommand(cmd *cobra.Command, args []string) error {
 func (sCmd *SpaceCommand) ResultPlainOutput() error {
 	return output.FinalCmdOutputPlain(&sCmd.FinalCurveCmd)
 }
+
+func GetSpaceStatus(caller *cobra.Command) (*interface{}, *tablewriter.Table, *cmderror.CmdError, cobrautil.ClUSTER_HEALTH_STATUS) {


return *tablewriter.Table is ugly, user can use sCmd.Result by parsing it.

What does mean? cmd.Result is all rows not a table obj and can not render it directly.

What does mean? cmd.Result is all rows not a table obj and can not render it directly.

The table object is a list, and it is very ugly to match.

Xinlong-Chen · 2023-06-13T07:58:49Z

tools-v2/pkg/cli/command/curvebs/status/chunkserver/chunkserver.go

@@ -120,3 +121,19 @@ func NewStatusChunkServerCommand() *ChunkServerCommand {
 func NewChunkServerCommand() *cobra.Command {
 	return NewStatusChunkServerCommand().Cmd
 }
+
+func GetChunkserverStatus(caller *cobra.Command) (*interface{}, *tablewriter.Table, *cmderror.CmdError, cobrautil.ClUSTER_HEALTH_STATUS) {


Xinlong-Chen · 2023-06-13T07:59:03Z

tools-v2/pkg/cli/command/curvebs/status/client/client.go

@@ -238,3 +242,19 @@ func NewStatusClientCommand() *ClientCommand {
 	basecmd.NewFinalCurveCli(&clientCmd.FinalCurveCmd, clientCmd)
 	return clientCmd
 }
+
+func GetClientStatus(caller *cobra.Command) (*interface{}, *tablewriter.Table, *cmderror.CmdError, cobrautil.ClUSTER_HEALTH_STATUS) {


Xinlong-Chen · 2023-06-13T08:01:29Z

tools-v2/pkg/cli/command/curvebs/status/client/client.go

@@ -92,9 +94,7 @@ func (cCmd *ClientCommand) Init(cmd *cobra.Command, args []string) error {
 	}

 	if len((*results).([]map[string]string)) == 0 {
-		retErr := cmderror.ErrBsGetClientStatus()


delete this error number in tools-v2/internal/error/error.go?

The err code is used by func GetClientStatus.

Xinlong-Chen · 2023-06-13T08:03:51Z

tools-v2/pkg/cli/command/curvebs/status/client/client.go

@@ -123,6 +123,10 @@ func (cCmd *ClientCommand) Print(cmd *cobra.Command, args []string) error {
 }

 func (cCmd *ClientCommand) RunCommand(cmd *cobra.Command, args []string) error {
+	if len(cCmd.metrics) == 0 {


when users use this command directly(he don't create any client), they will get nothings by this way. This is strange for users.

Xinlong-Chen · 2023-06-13T08:07:06Z

tools-v2/pkg/cli/command/curvebs/status/cluster/cluster.go

+}
+
+func (cCmd *ClusterCommand) AddFlags() {
+	config.AddRpcRetryTimesFlag(cCmd.Cmd)


all sub-command flags ought to add this command.

Xinlong-Chen · 2023-06-13T08:08:44Z

tools-v2/pkg/cli/command/curvebs/status/copyset/copyset.go

@@ -104,3 +105,19 @@ func NewStatusCopysetCommand() *CopysetCommand {
 	basecmd.NewFinalCurveCli(&copysetCmd.FinalCurveCmd, copysetCmd)
 	return copysetCmd
 }
+
+func GetCopysetsStatus(caller *cobra.Command) (*interface{}, *tablewriter.Table, *cmderror.CmdError, cobrautil.ClUSTER_HEALTH_STATUS) {


Xinlong-Chen · 2023-06-13T08:12:11Z

tools-v2/pkg/cli/command/curvebs/status/etcd/etcd.go

@@ -204,7 +205,7 @@ func NewStatusEtcdCommand() *EtcdCommand {
 	return etcdCmd
 }

-func GetEtcdStatus(caller *cobra.Command) (*interface{}, *cmderror.CmdError, cobrautil.ClUSTER_HEALTH_STATUS) {
+func GetEtcdStatus(caller *cobra.Command) (*interface{}, *tablewriter.Table, *cmderror.CmdError, cobrautil.ClUSTER_HEALTH_STATUS) {


@Cyber-SiKu please take a look this change. It's conflicting with what we discussed earlier.

@Cyber-SiKu please take a look this change. It's conflicting with what we discussed earlier.

Indeed, it seems strange to directly return a table here. I am thinking about whether this is possible? Directly synchronize the status cluster output format to the subcommand instead of simply setting it to noout? Calling this command in this way also has output, but the status cluster only cares about the inspection results of this step? But in this case, the output in jason format is difficult to handle.

why feel strange? I think that it should be understandable if the output of a command corresponds to a table object. status cluster is collection of these tables. The cmd.Result is all rows that seems like need to combine them into a table for output?

@Xinlong-Chen @caoxianfei1
At present, the output of the status cluster is too much, and it is difficult to recognize if the table is directly output. Can you combine the output like this:
services

role leader online offline

mds

etcd

snapshot

chunkserver -

copyset

total ok warn error

space

... ... ...

Of course, I think both methods are ok.

Xinlong-Chen · 2023-06-13T08:12:32Z

tools-v2/pkg/cli/command/curvebs/status/mds/mds.go

@@ -195,7 +196,7 @@ func NewStatusMdsCommand() *MdsCommand {
 	return mdsCmd
 }

-func GetMdsStatus(caller *cobra.Command) (*interface{}, *cmderror.CmdError, cobrautil.ClUSTER_HEALTH_STATUS) {
+func GetMdsStatus(caller *cobra.Command) (*interface{}, *tablewriter.Table, *cmderror.CmdError, cobrautil.ClUSTER_HEALTH_STATUS) {


Xinlong-Chen · 2023-06-13T08:12:44Z

tools-v2/pkg/cli/command/curvebs/status/snapshot/snapshot.go

@@ -205,7 +206,7 @@ func NewStatusSnapshotCommand() *SnapshotCommand {
 	return snapshotCmd
 }

-func GetSnapshotStatus(caller *cobra.Command) (*interface{}, *cmderror.CmdError, cobrautil.ClUSTER_HEALTH_STATUS) {
+func GetSnapshotStatus(caller *cobra.Command) (*interface{}, *tablewriter.Table, *cmderror.CmdError, cobrautil.ClUSTER_HEALTH_STATUS) {


Cyber-SiKu · 2023-06-14T03:38:47Z

tools-v2/pkg/cli/command/curvebs/status/cluster/cluster.go

+	for key, function := range cCmd.type2Func {
+		result, table, err, health := function(cmd)
+		cCmd.type2Table[key] = table
+		results[key] = *result


The case where result is nil is not handled.

Cyber-SiKu · 2023-06-14T03:40:05Z

tools-v2/pkg/cli/command/curvebs/status/cluster/cluster.go

+	}
+	finalErr := cmderror.MergeCmdErrorExceptSuccess(errs)
+	cCmd.Error = finalErr
+	results["health"] = cobrautil.ClusterHealthStatus_Str[int32(cCmd.health)]


Please add the definition of the constant in cobrautil.

Cyber-SiKu

LGTM

Cyber-SiKu · 2023-06-21T06:45:16Z

cicheck

Cyber-SiKu · 2023-06-21T06:45:37Z

@Xinlong-Chen you can take a look.

caoxianfei1 · 2023-06-21T06:50:47Z

@Xinlong-Chen PTAL？

Xinlong-Chen

still have some small questions~

Xinlong-Chen · 2023-06-21T07:06:35Z

tools-v2/pkg/cli/command/curvebs/list/space/space.go

+		retErr.Format(err.Error())
+		return nil, retErr, cobrautil.HEALTH_ERROR
+	}
+	fmt.Sprintln(sCmd.Result)


can delete debug command.

tools-v2/pkg/cli/command/curvebs/check/copyset/copyset.go

Signed-off-by: caoxianfei1 <caoxianfei@corp.netease.com>

Xinlong-Chen · 2023-06-25T06:07:48Z

cicheck

Cyber-SiKu requested review from Cyber-SiKu and Xinlong-Chen and removed request for Cyber-SiKu June 13, 2023 06:49

Cyber-SiKu reviewed Jun 13, 2023

View reviewed changes

Xinlong-Chen reviewed Jun 13, 2023

View reviewed changes

Cyber-SiKu reviewed Jun 14, 2023

View reviewed changes

caoxianfei1 force-pushed the feature/status-cluster branch 3 times, most recently from 03e7029 to 27fbff4 Compare June 20, 2023 09:49

caoxianfei1 force-pushed the feature/status-cluster branch 2 times, most recently from 94f86e7 to ca20577 Compare June 21, 2023 06:33

Cyber-SiKu reviewed Jun 21, 2023

View reviewed changes

Cyber-SiKu approved these changes Jun 21, 2023

View reviewed changes

Xinlong-Chen reviewed Jun 21, 2023

View reviewed changes

caoxianfei1 force-pushed the feature/status-cluster branch from ca20577 to 6ae4f8b Compare June 24, 2023 13:51

add bs status cluster

2e56ee3

Signed-off-by: caoxianfei1 <caoxianfei@corp.netease.com>

caoxianfei1 force-pushed the feature/status-cluster branch from 6ae4f8b to 2e56ee3 Compare June 25, 2023 06:06

Xinlong-Chen approved these changes Jun 25, 2023

View reviewed changes

Cyber-SiKu merged commit 746f2c1 into opencurve:master Jun 26, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[feat] tools-v2: add bs status cluster #2530

[feat] tools-v2: add bs status cluster #2530

caoxianfei1 commented Jun 13, 2023 •

edited

Loading

Cyber-SiKu commented Jun 13, 2023

Cyber-SiKu left a comment

Cyber-SiKu Jun 13, 2023

Xinlong-Chen left a comment

Xinlong-Chen Jun 13, 2023

caoxianfei1 Jun 14, 2023 •

edited

Loading

Cyber-SiKu Jun 20, 2023

Xinlong-Chen Jun 13, 2023

Xinlong-Chen Jun 13, 2023

Xinlong-Chen Jun 13, 2023

caoxianfei1 Jun 14, 2023 •

edited

Loading

Xinlong-Chen Jun 13, 2023

Xinlong-Chen Jun 13, 2023

Xinlong-Chen Jun 13, 2023

Xinlong-Chen Jun 13, 2023

Cyber-SiKu Jun 14, 2023 •

edited

Loading

caoxianfei1 Jun 14, 2023

Cyber-SiKu Jun 14, 2023

caoxianfei1 Jun 14, 2023

Xinlong-Chen Jun 13, 2023

Xinlong-Chen Jun 13, 2023

Cyber-SiKu Jun 14, 2023

Cyber-SiKu Jun 14, 2023

Cyber-SiKu left a comment

Cyber-SiKu commented Jun 21, 2023

Cyber-SiKu commented Jun 21, 2023

caoxianfei1 commented Jun 21, 2023

Xinlong-Chen left a comment

Xinlong-Chen Jun 21, 2023

caoxianfei1 Jun 24, 2023

Xinlong-Chen commented Jun 25, 2023

	return NewInternalCmdError(66, "list space status fail, err: %s")
	return NewInternalCmdError(67, "list space status fail, err: %s")

[feat] tools-v2: add bs status cluster #2530

[feat] tools-v2: add bs status cluster #2530

Conversation

caoxianfei1 commented Jun 13, 2023 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Check List

Cyber-SiKu commented Jun 13, 2023

Cyber-SiKu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Xinlong-Chen left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

caoxianfei1 Jun 14, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

caoxianfei1 Jun 14, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Cyber-SiKu Jun 14, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Cyber-SiKu left a comment

Choose a reason for hiding this comment

Cyber-SiKu commented Jun 21, 2023

Cyber-SiKu commented Jun 21, 2023

caoxianfei1 commented Jun 21, 2023

Xinlong-Chen left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Xinlong-Chen commented Jun 25, 2023

caoxianfei1 commented Jun 13, 2023 •

edited

Loading

caoxianfei1 Jun 14, 2023 •

edited

Loading

caoxianfei1 Jun 14, 2023 •

edited

Loading

Cyber-SiKu Jun 14, 2023 •

edited

Loading