Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]tools-v2:curve bs check chunkserver #2632

Merged

Conversation

lng2020
Copy link
Contributor

@lng2020 lng2020 commented Jul 19, 2023

What problem does this PR solve?

Issue Number: #2353

Problem Summary:

What is changed and how it works?

What's Changed: ./pkg/cli/command/check/chunkserver, ./pkg/cli/command/check/check.go and README.md

How it Works: use wrapper function GetCopySetsInChunkServer to get the copyset list in chunkserver, then use wrapper function CheckCopysets to check copysets.

Side effects(Breaking backward compatibility? Performance regression?):

Check List

  • Relevant documentation/comments is changed or added
  • [x]] I acknowledge that all my contributions will be made under the project's license

@lng2020 lng2020 force-pushed the feature/curve-bs-check-chunkserver branch from fac5a3e to cec501e Compare July 20, 2023 06:51
@lng2020 lng2020 changed the title [feat]tool-v2:curve bs check chunkserver [feat]tools-v2:curve bs check chunkserver Jul 20, 2023
)

const (
chunkserverExample = `$ curve bs check chunkserver -chunkserverid=1`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using -- instead of -

@caoxianfei1
Copy link
Contributor

hi @lng2020 , you can rebase the commit and fix conflict then push it again.

@Cyber-SiKu
Copy link
Contributor

@lng2020 PRMF

@lng2020 lng2020 force-pushed the feature/curve-bs-check-chunkserver branch from cec501e to 1589173 Compare July 31, 2023 07:19
Signed-off-by: lng2020 <nanguanlin6@gmail.com>
@lng2020 lng2020 force-pushed the feature/curve-bs-check-chunkserver branch from 1589173 to 9325b11 Compare July 31, 2023 07:26
@Cyber-SiKu
Copy link
Contributor

cicheck

@Cyber-SiKu Cyber-SiKu merged commit fdb3722 into opencurve:master Aug 1, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants