[feat]: curvefs: merge two rpc into one when delete #2744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
201341
force-pushed
the
swj/opt-deletenode
branch
3 times, most recently
from
a0aafd4
to
0ef9c99
Compare
|
cicheck |
|
sorry, now need rebase. |
201341
force-pushed
the
swj/opt-deletenode
branch
3 times, most recently
from
c553928
to
75e591e
Compare
|
cicheck |
wu-hanqing
reviewed
Oct 23, 2023
Comment on lines
324
to
329
| struct timespec now; | ||
| clock_gettime(CLOCK_REALTIME, &now); | ||
| Time* tm = new Time(); | ||
| tm->set_sec(now.tv_sec); | ||
| tm->set_nsec(now.tv_nsec); | ||
| request.set_allocated_time(tm); |
There was a problem hiding this comment.
These codes are repeated multiple times, e.g., L258-263, consider extra into a function.
curvefs/src/metaserver/metastore.cpp
Outdated
Comment on lines
431
to
439
| uint64_t now = 0; | ||
| uint32_t now_ns = 0; | ||
| if (request->has_time()) { | ||
| now = request->time().sec(); | ||
| now_ns = request->time().nsec(); | ||
| } | ||
| Time tm; | ||
| tm.set_sec(now); | ||
| tm.set_nsec(now_ns); |
There was a problem hiding this comment.
ditto, repeated with L369
201341
force-pushed
the
swj/opt-deletenode
branch
6 times, most recently
from
2f78fb7
to
147109e
Compare
|
cicheck |
201341
force-pushed
the
swj/opt-deletenode
branch
from
147109e
to
f64f561
Compare
|
cicheck |
2 similar comments
|
cicheck |
|
cicheck |
wu-hanqing
reviewed
Oct 25, 2023
Comment on lines
110
to
115
| Time* MetaServerClientImpl::CreateTime() { | ||
| struct timespec now; | ||
| clock_gettime(CLOCK_REALTIME, &now); | ||
| Time* tm = new Time(); | ||
| tm->set_sec(now.tv_sec); | ||
| tm->set_nsec(now.tv_nsec); | ||
| return tm; | ||
| } |
There was a problem hiding this comment.
It would be more appropriate to do something like this,
void SetCreateTime(Time* tm) {
struct timespec now;
clock_gettime(CLOCK_REALTIME, &now);
tm->set_sec(now.tv_sec);
tm->set_nsec(now.tv_nsec);
}
// caller
SetCreateTime(request.mutable_create());
201341
force-pushed
the
swj/opt-deletenode
branch
2 times, most recently
from
8ff8452
to
7c46d16
Compare
|
cicheck |
1 similar comment
|
cicheck |
wu-hanqing
approved these changes
Nov 1, 2023
| @@ -107,6 +107,13 @@ class MetaServerClientRpcDoneBase : public google::protobuf::Closure { | |||
| MetaServerClientMetric *metric_; | |||
| }; | |||
|
|
|||
| void MetaServerClientImpl::SetCreateTime(Time* tm) { | |||
There was a problem hiding this comment.
SetCreateTime should not be a member function, define it as a free function is ok.
201341
force-pushed
the
swj/opt-deletenode
branch
from
7c46d16
to
66c5af7
Compare
|
cicheck |
Signed-off-by: swj <1186093704@qq.com>
201341
force-pushed
the
swj/opt-deletenode
branch
from
66c5af7
to
f546ecb
Compare
|
cicheck |
|
@SeanHai PTAL |
SeanHai
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: #2548
Problem Summary:
What is changed and how it works?
What's Changed:
How it Works:
Side effects(Breaking backward compatibility? Performance regression?):
Check List