[feat]tools-v2: optimize bs delete volume xxx and define result code … #2777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cicheck |
Cyber-SiKu
reviewed
Sep 28, 2023
| if err.TypeCode() != cmderror.CODE_SUCCESS { | ||
| item["Result"] = "fail" | ||
| item["Result"] = cobrautil.ROW_VALUE_FAILED |
There was a problem hiding this comment.
"Result" Please define it as a constant
| } | ||
| item["Result"] = cobrautil.ROW_VALUE_SUCCESS | ||
| rCmd.TableNew.Append([]string{item["User"], item["Src"], item["UUID"], item["File"], item["Result"]}) |
There was a problem hiding this comment.
Please define it as a constant
| item["Result"] = "success" | ||
| payload := map[string]any{} | ||
| if err := json.Unmarshal([]byte(result), &payload); err != nil { | ||
| item["Result"] = cobrautil.ROW_VALUE_FAILED |
| item["Result"] = cobrautil.ROW_VALUE_FAILED | ||
| } else { | ||
| if payload[cobrautil.ResultCode] != cobrautil.ResultSuccess { | ||
| item["Result"] = cobrautil.ROW_VALUE_FAILED |
…as constant Signed-off-by: baytan0720 <baytan2@hotmail.com>
|
cicheck |
2 similar comments
|
cicheck |
|
cicheck |
Cyber-SiKu
approved these changes
Oct 8, 2023
caoxianfei1
approved these changes
Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…as constant
What problem does this PR solve?
Issue Number: #xxx
Problem Summary:
optimize use sync.WaitGroup, define result status code as constant
What is changed and how it works?
What's Changed:
How it Works:
Side effects(Breaking backward compatibility? Performance regression?):
Check List