ansible: improve daemon restart #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanHai
force-pushed
the
ansible_fix_when_warning
branch
from
ed959db
to
8d0947d
Compare
ilixiaocui
reviewed
Apr 15, 2021
| sudo: "sudo" | ||
| when: command_need_sudo | ||
|
|
||
| - name: restart nebd-server with daemon |
There was a problem hiding this comment.
Why not reuse the above restart module
There was a problem hiding this comment.
Why not reuse the above restart module
Cannot use service_port to check the nebd-server up or not after nebd-server restart. But the others can.
refix the restart_service.yml to support reuse.
done
cw123
requested changes
Apr 15, 2021
|
|
||
| - name: restart service without daemon | ||
| block: | ||
| - name: stop service without daemon |
There was a problem hiding this comment.
Is here need wait until server is down？
There was a problem hiding this comment.
Is here need wait until server is down？
done
SeanHai
force-pushed
the
ansible_fix_when_warning
branch
from
8d0947d
to
da4129b
Compare
ilixiaocui
approved these changes
Apr 16, 2021
cw123
approved these changes
Apr 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
What is changed and how it works?
What's Changed:
How it Works:
Side effects(Breaking backward compatibility? Performance regression?):
Check List