chunkserver : fix bug in trash when collecting chunknum miss chunk in… #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanHai
reviewed
Jul 9, 2021
src/chunkserver/trash.cpp
Outdated
|
|
||
| uint32_t chunkNum = 0; | ||
| for (auto& chunk : chunks) { | ||
| // 遍历子文件 |
| @@ -594,14 +593,30 @@ TEST_F(TrashTest, test_chunk_num_statistic) { | |||
| std::vector<std::string> logfiles2{}; | |||
|
|
|||
| // (1) chunk exists when init | |||
| // trash/ | |||
There was a problem hiding this comment.
Not include the scenario bug triggered? Like '/data/chunkserver1/recycler/8589936511.1625810976/raft_snapshot/temp/data/chunk_10000'
… raft_snapshot dir
SeanHai
approved these changes
Jul 9, 2021
ilixiaocui
approved these changes
Jul 9, 2021
ilixiaocui
pushed a commit
to ilixiaocui/curve
that referenced
this pull request
Feb 6, 2023
Update project_ideas.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… raft_snapshot dir
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
What is changed and how it works?
What's Changed:
How it Works:
Side effects(Breaking backward compatibility? Performance regression?):
Check List