Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silence redundant-move warning #15

Merged
merged 1 commit into from
Jun 13, 2019
Merged

Silence redundant-move warning #15

merged 1 commit into from
Jun 13, 2019

Conversation

xerus
Copy link
Contributor

@xerus xerus commented Jun 13, 2019

Happens with gcc-9.1

/home/pgrunt/src/ade/sources/ade/source/execution_engine.cpp: In member function ‘std::unique_ptr<ade::Executable> ade::ExecutionEngine::createExecutable(const ade::Graph&)’:
/home/pgrunt/src/ade/sources/ade/source/execution_engine.cpp:141:21: error: redundant move in return statement [-Werror=redundant-move]
  141 |     return std::move(ret);
      |            ~~~~~~~~~^~~~~

@xerus
Silence redundant-move warning
08238a4 
Happens with gcc-9.1
@dmatveev dmatveev requested a review from Hardcode84 June 13, 2019 14:11
@dmatveev
Copy link
Collaborator

Pavel, thanks!

@Hardcode84 Ivan please have a look :)

Hardcode84
Hardcode84 approved these changes Jun 13, 2019
View reviewed changes
Copy link
Collaborator

@Hardcode84 Hardcode84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hardcode84 Hardcode84 merged commit e80509b into opencv:master Jun 13, 2019
@andrey-golubev andrey-golubev mentioned this pull request Aug 6, 2019
Merged
taowan1 pushed a commit to projectceladon/ade that referenced this pull request Sep 4, 2019
@xerus @Hardcode84
Silence redundant-move warning (opencv#15)
5b624f9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hardcode84 Hardcode84 Hardcode84 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xerus @dmatveev @Hardcode84