Don't override CMAKE_CXX_STANDARD set by parent projects #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmatveev
approved these changes
Oct 10, 2023
|
Fixing build in #41 |
|
Messed up with ctest, #42 is the fix |
|
It seems the current Actions setup doesn't put patch atop of the master but tests the original branch itself, @ilya-lavrenov can you please pull the latest master in? |
ilya-lavrenov
force-pushed
the
patch-1
branch
from
9c4766c
to
2589414
Compare
When ADE used as a submodule, it overrides CMAKE_CXX_STANDARD set by parent project. E.g. parent projects defines CMAKE_CXX_STANDARD as 14 and during first cmake run it's applied, but during second cmake run ADE's value is used from cache. No needs to keep CMAKE_CXX_STANDARD in cache, because it may vary from project to project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When ADE used as a submodule, it overrides CMAKE_CXX_STANDARD set by parent project. E.g. parent projects defines CMAKE_CXX_STANDARD as 14 and during first cmake run it's applied, but during second cmake run ADE's value is used from cache. No needs to keep CMAKE_CXX_STANDARD in cache, because it may vary from project to project.