Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for scalar and matrix multiplication in einsum #25595

Merged
merged 4 commits into from
May 21, 2024
Merged

Add support for scalar and matrix multiplication in einsum #25595

merged 4 commits into from
May 21, 2024

Conversation

Abdurrahheem
Copy link
Contributor

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@Abdurrahheem Abdurrahheem added this to the 5.0 milestone May 15, 2024
@Abdurrahheem Abdurrahheem self-assigned this May 15, 2024
@Abdurrahheem Abdurrahheem marked this pull request as ready for review May 16, 2024 15:45
@Abdurrahheem
Copy link
Contributor Author

@dkurt, this is ready for review

@asmorkalov asmorkalov requested a review from savuor May 17, 2024 08:05
@asmorkalov asmorkalov added feature category: dnn (onnx) ONNX suport issues in DNN module labels May 17, 2024
savuor
savuor approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@savuor savuor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to arithm_op look OK

Abdurrahheem and others added 2 commits May 20, 2024 14:02
asmorkalov
asmorkalov approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov merged commit f676cb3 into opencv:5.x May 21, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

@savuor savuor savuor approved these changes

@dkurt dkurt dkurt approved these changes

Assignees

@Abdurrahheem Abdurrahheem

Labels
category: dnn (onnx) ONNX suport issues in DNN module feature
Projects
None yet
Milestone
5.0-alpha
Development

Successfully merging this pull request may close these issues.
4 participants
@Abdurrahheem @asmorkalov @savuor @dkurt