Synthetic benchmark for Aruco/Charuco/chessboard detection #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmorkalov
changed the title
|
General notes:
|
asmorkalov
reviewed
Sep 8, 2023
| return rvec, tvec | ||
|
|
||
|
|
||
| def get_coord(num_rows, num_cols, start_x=0, start_y=0): |
There was a problem hiding this comment.
what coordinates? please rename.
Comment on lines
161
to
168
| self.cameraMatrix = np.eye(3, 3, dtype=np.float64) | ||
| self.cameraMatrix[0, 0] = img_size[0] | ||
| self.cameraMatrix[1, 1] = img_size[0] | ||
| self.cameraMatrix[0, 2] = img_size[0] / 2 | ||
| self.cameraMatrix[1, 2] = img_size[0] / 2 | ||
| self.distCoeffs = np.zeros((4, 1), np.float64) | ||
| self.distCoeffs[0] = -0.5012997 | ||
| self.distCoeffs[1] = -0.50116057 |
There was a problem hiding this comment.
I propose to run the camera parameters from file, e.g. xml generated by calibration.
asmorkalov
reviewed
Sep 18, 2023
Comment on lines
482
to
484
| print(folder) | ||
| print("detected", res[0]/res[1], "total", res[1], "distance", res[2]/max(res[1], 1), | ||
| "detected", res[3]/res[4], "total", res[4], "distance", res[5]/max(res[4], 1),) |
There was a problem hiding this comment.
Let's format it as human-readable table.
|
General notes:
|
|
AleksandrPanov
changed the title
AleksandrPanov
changed the title
AleksandrPanov
changed the title
|
Remaining items:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.