Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc thinning fixes. #3743

Merged
merged 2 commits into from
May 30, 2024
Merged

Misc thinning fixes. #3743

merged 2 commits into from
May 30, 2024

Conversation

vrabaud
Copy link
Contributor

@vrabaud vrabaud commented May 24, 2024

  • edges could be modified
  • 2 sets of iterations were always done even if the first set did not return any change
  • countNonZero is slow compared to hasNonZero

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.

@vrabaud vrabaud requested a review from asmorkalov May 24, 2024 09:35
@vrabaud
Misc thinning fixes.
2c237bb 
- edges could be modified
- 2 sets of iterations were always done even if the first set did
  not return any change
- countNonZero is slow compared to hasNonZero
@vrabaud
Use absdiff to avoid saturation
270fcd1
asmorkalov
asmorkalov approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov merged commit d131e7a into opencv:4.x May 30, 2024
10 of 11 checks passed
@vrabaud vrabaud deleted the thinning branch May 30, 2024 13:18
@mshabunin mshabunin mentioned this pull request Jun 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees
No one assigned
Labels
category: ximgproc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vrabaud @asmorkalov