Secretserver develop #1092

Deepshikha8514 · 2022-08-29T05:46:22Z

No description provided.

codecov · 2022-08-29T05:48:49Z

Codecov Report

Base: 64.57% // Head: 64.55% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (0bc5cd2) compared to base (9a6037e).
Patch coverage: 2.85% of modified lines in pull request are covered.

❗ Current head 0bc5cd2 differs from pull request most recent head d8ce667. Consider uploading reports for the commit d8ce667 to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1092      +/-   ##
===========================================
- Coverage    64.57%   64.55%   -0.03%     
===========================================
  Files          541      541              
  Lines        50910    50926      +16     
===========================================
  Hits         32877    32877              
- Misses       18033    18049      +16

Impacted Files	Coverage Δ
...dules/secretserver/stix_transmission/api_client.py	`9.12% <0.00%> (-0.60%)`	⬇️
...tix_translation/test_secretserver_stix_to_query.py	`100.00% <100.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

delliott90 · 2022-08-29T14:44:32Z

stix_shifter_modules/secretserver/stix_translation/json/event_from_stix_map.json

@@ -14,28 +14,21 @@
    }
  },

-  "user-account": {


Why remove this and stick it in a custom object? When possible, standard STIX objects should be used.

Done the changes

delliott90 · 2022-08-29T14:46:07Z

stix_shifter_modules/secretserver/stix_translation/json/event_from_stix_map.json

  "x-secret": {
    "fields": {
      "secret_name": ["SecretName"],
-      "user_name": ["username"],
+      "username": ["EmailAddress"],


If this is an email address, it should go under the email-addr:value property.

Done the changes: https://github.com/Deepshikha8514/stix-shifter/blob/secretserver_develop/stix_shifter_modules/secretserver/stix_translation/json/event_from_stix_map.json#L16

delliott90 · 2022-09-09T14:00:53Z

stix_shifter_modules/secretserver/stix_translation/json/event_from_stix_map.json

  "x-secret": {
    "fields": {
      "secret_name": ["SecretName"],
-      "user_name": ["username"],
+      "username": ["Unique_Identtification"],


Couldn't this go in user-account:display_name instead of this custom object.

We have done our db parser changes with the above mapping. If it is not mandatory, Can it be taken for next release?

How is Unique_Identification different from the username field? This can likely remain where it is if they are different.

delliott90 · 2022-09-09T14:01:38Z

stix_shifter_modules/secretserver/stix_translation/json/event_from_stix_map.json

      "secret_id": ["ItemId"],
-      "user_id": ["UserId"]
+      "user_id": ["UserId"],


Why is this not just in the user-account:user_id object? No need to put it in a custom object.

delliott90 · 2022-09-09T14:03:11Z

stix_shifter_modules/secretserver/stix_translation/json/stix_2_1/event_from_stix_map.json

+  "x-secret": {
+    "fields": {
+      "secret_name": ["SecretName"],
+      "username": ["EmailAddress"],


This should be in a email-addr:value property and not a custom object

delliott90 · 2022-09-09T14:03:49Z

stix_shifter_modules/secretserver/stix_translation/json/stix_2_1/event_from_stix_map.json

+      "secret_name": ["SecretName"],
+      "username": ["EmailAddress"],
+      "secret_id": ["ItemId"],
+      "user_id": ["UserId"],


This should be in a user-account:user_id property

delliott90 · 2022-09-09T14:03:58Z

stix_shifter_modules/secretserver/stix_translation/json/stix_2_1/event_from_stix_map.json

+      "username": ["EmailAddress"],
+      "secret_id": ["ItemId"],
+      "user_id": ["UserId"],
+      "server_user_name" : ["Username"]


This should be in a user-account:display_name property

We have done our db parser changes with the above mapping. If it is not mandatory, Can it be taken for next release?

delliott90 · 2022-09-21T14:19:06Z

stix_shifter_modules/secretserver/stix_translation/json/event_from_stix_map.json

-      "user_id": [
-        "UserId"
-      ]
+      "user_name": ["username"],


This property needs to be display_name, there is no user_name property on the user-account object.

Done the changes

delliott90 · 2022-09-21T14:22:53Z

stix_shifter_modules/secretserver/stix_translation/json/stix_2_1/to_stix_map.json

+{
+  "username": [
+    {
+    "key": "user-account.user_name"


should be user-account.display_name

Done the changes

Deepshikha8514 added 5 commits August 29, 2022 11:10

Update event_from_stix_map.json

6ee2aca

Update to_stix_map.json

4102f0b

Add files via upload

ae35628

Update api_client.py

21c6457

Update test_secretserver_stix_to_query.py

31763ab

delliott90 reviewed Aug 29, 2022

View reviewed changes

Deepshikha8514 added 3 commits September 6, 2022 15:09

Update to_stix_map.json

d5d3dd7

Update event_from_stix_map.json

f618b6d

Update event_from_stix_map.json

ffa87cf

delliott90 reviewed Sep 9, 2022

View reviewed changes

Deepshikha8514 added 11 commits September 12, 2022 16:33

Update event_from_stix_map.json

8d62f81

Update to_stix_map.json

eec68b1

Update event_from_stix_map.json

0128e71

Update to_stix_map.json

60e9443

Update event_from_stix_map.json

ad4b951

Update to_stix_map.json

f1d5515

Update event_from_stix_map.json

741a1fc

Update event_from_stix_map.json

37084c0

Update to_stix_map.json

528ac91

Update event_from_stix_map.json

185c4ca

Update to_stix_map.json

c136797

delliott90 reviewed Sep 21, 2022

View reviewed changes

Update event_from_stix_map.json

3e61698

Deepshikha8514 added 3 commits September 22, 2022 15:12

Update to_stix_map.json

0175050

Update event_from_stix_map.json

aab6670

Update to_stix_map.json

0bc5cd2

delliott90 approved these changes Sep 26, 2022

View reviewed changes

Merge branch 'develop' into secretserver_develop

d8ce667

delliott90 merged commit ceeb9bb into opencybersecurityalliance:develop Sep 26, 2022

delliott90 pushed a commit that referenced this pull request Nov 25, 2022

Update Secretserver mappings (#1092)

262bee0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Secretserver develop #1092

Secretserver develop #1092

Deepshikha8514 commented Aug 29, 2022

codecov bot commented Aug 29, 2022 •

edited

delliott90 Aug 29, 2022

Deepshikha8514 Sep 6, 2022

delliott90 Aug 29, 2022

Deepshikha8514 Sep 6, 2022

delliott90 Sep 9, 2022

Deepshikha8514 Sep 12, 2022 •

edited

delliott90 Sep 21, 2022

delliott90 Sep 9, 2022

Deepshikha8514 Sep 12, 2022

delliott90 Sep 9, 2022 •

edited

Deepshikha8514 Sep 12, 2022

delliott90 Sep 9, 2022

Deepshikha8514 Sep 12, 2022

delliott90 Sep 9, 2022

Deepshikha8514 Sep 12, 2022 •

edited

delliott90 Sep 21, 2022

Deepshikha8514 Sep 22, 2022

delliott90 Sep 21, 2022

Deepshikha8514 Sep 22, 2022

Secretserver develop #1092

Secretserver develop #1092

Conversation

Deepshikha8514 commented Aug 29, 2022

codecov bot commented Aug 29, 2022 • edited

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Deepshikha8514 Sep 12, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

delliott90 Sep 9, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Deepshikha8514 Sep 12, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Aug 29, 2022 •

edited

Deepshikha8514 Sep 12, 2022 •

edited

delliott90 Sep 9, 2022 •

edited

Deepshikha8514 Sep 12, 2022 •

edited