-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Secretserver develop #1092
Secretserver develop #1092
Changes from 5 commits
6ee2aca
4102f0b
ae35628
21c6457
31763ab
d5d3dd7
f618b6d
ffa87cf
8d62f81
eec68b1
0128e71
60e9443
ad4b951
f1d5515
741a1fc
37084c0
528ac91
185c4ca
c136797
3e61698
0175050
aab6670
0bc5cd2
d8ce667
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,28 +14,21 @@ | |
} | ||
}, | ||
|
||
"user-account": { | ||
"fields": { | ||
"user_id": [ | ||
"UserId" | ||
] | ||
} | ||
}, | ||
"x-secret": { | ||
"fields": { | ||
"secret_name": ["SecretName"], | ||
"user_name": ["username"], | ||
"username": ["EmailAddress"], | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If this is an email address, it should go under the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
"secret_id": ["ItemId"], | ||
"user_id": ["UserId"] | ||
"user_id": ["UserId"], | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why is this not just in the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done |
||
"server_user_name" : ["Username"] | ||
} | ||
}, | ||
"x-ibm-finding": { | ||
"fields": { | ||
"name": ["EventSubject"], | ||
"event_name": ["EventSubject"], | ||
"description": ["EventNote"], | ||
"finding_type": ["EventDetails"], | ||
"time_observed": ["EventTime"] | ||
} | ||
} | ||
} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
{ | ||
"ipv4-addr": { | ||
"fields": { | ||
"value": ["IpAddress", "Server"], | ||
"src_ip": ["IpAddress"], | ||
"dst_ip": ["Server"] | ||
} | ||
}, | ||
"url": { | ||
"fields": { | ||
"value": [ | ||
"url" | ||
] | ||
} | ||
}, | ||
|
||
"x-secret": { | ||
"fields": { | ||
"secret_name": ["SecretName"], | ||
"username": ["EmailAddress"], | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should be in a There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done |
||
"secret_id": ["ItemId"], | ||
"user_id": ["UserId"], | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should be in a There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done |
||
"server_user_name" : ["Username"] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should be in a There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We have done our db parser changes with the above mapping. If it is not mandatory, Can it be taken for next release? |
||
} | ||
}, | ||
"x-ibm-finding": { | ||
"fields": { | ||
"event_name": ["EventSubject"], | ||
"description": ["EventNote"], | ||
"finding_type": ["EventDetails"], | ||
"time_observed": ["EventTime"] | ||
} | ||
} | ||
} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,83 @@ | ||
{ | ||
"IpAddress": [ | ||
{ | ||
"key": "ipv4-addr.value", | ||
"object": "src_ip" | ||
}, | ||
{ | ||
"key": "x-ibm-finding.src_ip_ref", | ||
"object": "finding", | ||
"references": "src_ip" | ||
} | ||
], | ||
"Server": [ | ||
{ | ||
"key": "ipv4-addr.value", | ||
"object": "dst_ip" | ||
}, | ||
{ | ||
"key": "x-ibm-finding.dst_ip_ref", | ||
"object": "finding", | ||
"references": "dst_ip" | ||
} | ||
], | ||
|
||
"StartTime": [ | ||
{ | ||
"key": "first_observed", | ||
"transformer": "EpochToTimestamp", | ||
"cybox": false | ||
}, | ||
{ | ||
"key": "last_observed", | ||
"transformer": "EpochToTimestamp", | ||
"cybox": false | ||
} | ||
], | ||
"Url": { | ||
"key": "url.value" | ||
}, | ||
|
||
"EventSubject" : | ||
{ | ||
"key": "x-ibm-finding.event_name", | ||
"object": "finding" | ||
}, | ||
"EventNote": | ||
{ | ||
"key": "x-ibm-finding.description", | ||
"object": "finding" | ||
}, | ||
"EventDetails": | ||
{ | ||
"key": "x-ibm-finding.finding_type", | ||
"object": "finding" | ||
}, | ||
"EventTime": | ||
{ | ||
"key": "x-ibm-finding.time_observed", | ||
"object": "finding" | ||
}, | ||
|
||
"SecretName": | ||
{ | ||
"key": "x-secret.secret_name", | ||
"object": "secret" | ||
}, | ||
"ItemId": { | ||
"key": "x-secret.secret_id", | ||
"object": "secret" | ||
}, | ||
"UserId": { | ||
"key": "x-secret.user_id", | ||
"object": "secret" | ||
}, | ||
"EmailAddress": { | ||
"key": "x-secret.username", | ||
"object": "secret" | ||
}, | ||
"Username": { | ||
"key": "x-secret.server_user_name", | ||
"object": "secret" | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why remove this and stick it in a custom object? When possible, standard STIX objects should be used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done the changes