Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of StixObjectIdEncoder #1124

Merged
merged 3 commits into from
Sep 21, 2022
Merged

Conversation

baulus
Copy link
Contributor

@baulus baulus commented Sep 20, 2022

No description provided.

@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Base: 64.57% // Head: 64.57% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (f674a25) compared to base (c6d2e74).
Patch coverage: 60.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1124   +/-   ##
========================================
  Coverage    64.57%   64.57%           
========================================
  Files          541      541           
  Lines        50912    50910    -2     
========================================
  Hits         32877    32877           
+ Misses       18035    18033    -2     
Impacted Files Coverage Δ
...lation/src/json_to_stix/json_to_stix_translator.py 78.50% <50.00%> (ø)
stix_shifter_utils/utils/helpers.py 49.15% <66.66%> (+1.61%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mdazam1942 mdazam1942 merged commit 9a6037e into develop Sep 21, 2022
@mdazam1942 mdazam1942 deleted the get-rid-of-StixObjectIdEncoder branch September 21, 2022 14:51
AmitHaim1 pushed a commit to aviv1ron1/stix-shifter that referenced this pull request Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants