Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the x-ecs-process and x-ecs-file entities from elastic_ecs mapping #1335

Merged
merged 39 commits into from
Mar 2, 2023

Conversation

cmadam
Copy link
Contributor

@cmadam cmadam commented Feb 17, 2023

This pull request aims to address issue #1334 (Remove the x-ecs-process and x-ecs-file entities from elastic_ecs mapping).

cmadam and others added 26 commits February 8, 2023 17:15
@CLAassistant
Copy link

CLAassistant commented Feb 17, 2023

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change

Comparison is base (8a82d3f) 85.42% compared to head (9b27302) 85.43%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1335   +/-   ##
========================================
  Coverage    85.42%   85.43%           
========================================
  Files          569      569           
  Lines        42693    42716   +23     
========================================
+ Hits         36471    36494   +23     
  Misses        6222     6222           
Impacted Files Coverage Δ
.../stix_translation/test_elastic_ecs_json_to_stix.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@mdazam1942 mdazam1942 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cmadam Can you please update stix2.1 mappings as well? stix_shifter_modules/elastic_ecs/stix_translation/json/stix_2_1

@mdazam1942 mdazam1942 merged commit cd24c2d into opencybersecurityalliance:develop Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the x-ecs-process and x-ecs-file entities from elastic_ecs mapping
5 participants