Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix two deprecation warnings #940

Merged
merged 4 commits into from
Jun 7, 2022
Merged

fix two deprecation warnings #940

merged 4 commits into from
Jun 7, 2022

Conversation

subbyte
Copy link
Member

@subbyte subbyte commented May 11, 2022

Get two warning when testing Kestrel:

tests/test_command_get.py::test_get_single_stixshifter_stix_bundle
tests/test_command_get.py::test_get_single_stixshifter_stix_bundle
tests/test_command_get.py::test_get_multiple_stixshifter_stix_bundles
tests/test_command_get.py::test_get_multiple_stixshifter_stix_bundles
tests/test_command_get.py::test_get_multiple_stixshifter_stix_bundles
tests/test_command_get.py::test_get_multiple_stixshifter_stix_bundles
  /kestrel-dev/lib64/python3.10/site-packages/stix_shifter_utils/stix_transmission/utils/RestApiClient.py:106: DeprecationWarning: Using 'method_whitelist' with Retry is deprecated and will be removed in v2.0. Use 'allowed_methods' instead
    retry_strategy = Retry(total=self.retry_max, backoff_factor=0, status_forcelist=[429, 500, 502, 503, 504],

tests/test_command_get.py::test_get_single_stixshifter_stix_bundle
tests/test_command_get.py::test_get_single_stixshifter_stix_bundle
tests/test_command_get.py::test_get_multiple_stixshifter_stix_bundles
tests/test_command_get.py::test_get_multiple_stixshifter_stix_bundles
tests/test_command_get.py::test_get_multiple_stixshifter_stix_bundles
tests/test_command_get.py::test_get_multiple_stixshifter_stix_bundles
  /kestrel-dev/lib64/python3.10/site-packages/stix_shifter_utils/stix_transmission/utils/RestApiClient.py:26: DeprecationWarning: setDaemon() is deprecated, set the daemon attribute instead
    self.setDaemon(True)

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html

@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #940 (9b4979d) into develop (0aee031) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #940   +/-   ##
========================================
  Coverage    64.73%   64.73%           
========================================
  Files          517      517           
  Lines        48855    48855           
========================================
  Hits         31627    31627           
  Misses       17228    17228           
Impacted Files Coverage Δ
...ter_utils/stix_transmission/utils/RestApiClient.py 52.43% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0aee031...9b4979d. Read the comment docs.

@subbyte subbyte requested a review from delliott90 May 26, 2022 21:53
@delliott90 delliott90 merged commit 32acefd into opencybersecurityalliance:develop Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants